[Payment due][$250] Centralize ExpensiMark usage with a dedicated Parser module

[blazejkustra]

Proposal:

• Create a Parser lib, where ExpensiMark is going to be imported and initialized only once
• Forbid importing ExpensiMark from expensify-common globally (can be easily done with ESLint)
• (optional) Pass Onyx context with a new ExpensiMark method instead of wrapping parseHtmlToText, parseHtmlToMarkdown like in src/libs/OnyxAwareParser.ts.

This way, there will be only one instance of ExpensiMark, and src/libs/Parser will be used throughout the codebase. This will potentially prevent regressions like this going forward.

Problems

1. ExpensiMark methods (parseHtmlToText, parseHtmlToMarkdown) should always be used with Onyx context. Otherwise server is spammed with a lot of errors like this.
2. We introduced OnyxAwareParser a while ago, but we can't expect everybody to know it's mandatory to use it. Instead contributors often import ExpensiMark, initialize it and use it's methods, which causes problems (like here).
3. ExpensiMark is initialized 14 times in E/App.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ddda297d9f5526e7
• Upwork Job ID: 1813359382413182920
• Last Price Increase: 2024-07-16
• Automatic offers:
• hoangzinh | Reviewer | 103148367

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Current assignee @neil-marcellini is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

[ShridharGoel]

Create a Parser lib, where ExpensiMark is going to be imported and initialized only once

Can we not use the existing OnyxAwareParser.ts with the needed modifications ?

[blazejkustra]

@ShridharGoel I think I'll reuse OnyxAwareParser.ts, but change the name to Parser to make it less verbose.

[blazejkustra]

I'll come back to this issue early next week as I'm OOO 27-30.06.

[neil-marcellini]

Not overdue, waiting for Blazej to come back.

[blazejkustra]

I'm on it, will update tomorrow :)

[blazejkustra]

Update: PR is ready for C+ review!

[hoangzinh]

@kadiealexander @neil-marcellini can you help to assign me and apply payment status here? I helped review this PR #44732. Thank you.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ddda297d9f5526e7

[melvin-bot]

Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[hoangzinh]

@kadiealexander I think we can apply "Awaiting Payment" label for this issue, the PR has been deployed to Production #44732 (comment)

[kadiealexander]

Payouts due:

• Contributor+: $250 @hoangzinh Offer link

Upwork job is here.

[hoangzinh]

@kadiealexander This issue is just a refactoring issue, therefore I think we don't have a BZ checklist.