[HOLD for payment 2024-07-10] Thread - Thread title not updated in header and in LHN after editing parent message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4675207
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Open any chat
3. Send a message and create a thread
4. Change the parent message to anything

Expected Result:

The thread title is updated in the header and in LHN

Actual Result:

The thread title still displays the parent message before editing. It updates in the header after opening the thread again, but does not change in the LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6524884_1719386508521.Recording__578.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@trjExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread title and LHN title doesn't update immediately when updating the thread parent message.

What is the root cause of that problem?

For the thread title, we get the title from getReportActionMessage which uses parseReportActionHtmlToText. parseReportActionHtmlToText has a cache mechanism with the cache key being the combination of the reportID, reportActionID, and the report action lastModified.

App/src/libs/ReportUtils.ts

Lines 3238 to 3242 in 0c20881

	const key = `${reportID}_${reportAction.reportActionID}_${reportAction.lastModified}`;
	const cachedText = parsedReportActionMessageCache[key];
	if (cachedText !== undefined) {
	return cachedText;
	}

There are 2 problems here. First, we don't optimistically update the lastModified when editing a message, so we rely on the BE response to update it. Second, we get the report action by using the deprecated getParentReportAction and since we enable the react-compiler in #42287, it means the component won't react to the parent report action updates because ReportUtils.getReportName only use the report data.

App/src/libs/ReportUtils.ts

Lines 3322 to 3324 in 0c20881

	function getReportName(report: OnyxEntry<Report>, policy?: OnyxEntry<Policy>): string {
	let formattedName: string | undefined;
	const parentReportAction = ReportActionsUtils.getParentReportAction(report);

What changes do you think we should make in order to solve the problem?

First, update the lastModified optimistically (and revert if fails).

App/src/libs/actions/Report.ts

Lines 1530 to 1543 in 0c20881

	const optimisticReportActions: PartialDeep<ReportActions> = {
	[reportActionID]: {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	message: [
	{
	...originalMessage,
	type: CONST.REPORT.MESSAGE.TYPE.COMMENT,
	isEdited: true,
	html: htmlForNewComment,
	text: reportComment,
	},
	],
	},
	};

This change alone is enough because the report data is also updated which triggers the getReportName, but we should start passing the parent report action as the 3rd param.

App/src/pages/home/HeaderView.tsx

Line 106 in 0c20881

const title = ReportUtils.getReportName(reportHeaderData);

const title = ReportUtils.getReportName(reportHeaderData, undefined, parentReportAction);

[trjExpensify]

Have we identified the PR on the staging checklist that broke this?

[bernhardoj]

I think it's the react-compiler.

In prod, I can see that the thread and LHN title are late to update.

Screen.Recording.2024-06-26.at.20.56.40.mov

But in main (or staging), the thread title is never updated which is worse than prod.

Screen.Recording.2024-06-26.at.21.21.22.mov

So, there are 2 problems, 1 is an old problem and the other one is caused by the react-compiler. (NOTE: it shows that the react-compiler did its job)

I have updated my proposal to mention the react-compiler PR.

[mountiny]

@kirillzyusko Could you check this out too please?

[mountiny]

FWIW the proposal from @bernhardoj makes sense

[kirillzyusko]

@mountiny yeah, the proposal looks good for me as well 👍

[bernhardoj]

PR is ready

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix thread title not updated in header and in LHN after editing parent message #44526

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: the bug stems from react compiler pr - [NoQA] feat: react-compiler #42287

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [NoQA] feat: react-compiler #42287 (review)

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. No because caught by QA and rca was react compiler which is one time thing.

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[trjExpensify]

Payment summary as follows:

• $250 to @bernhardoj for the fix
• $250 to @rushatgabhane for the review

Feel free to go ahead and request, both of you. Closing!

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj

[JmillsExpensify]

$250 approved for @rushatgabhane