[HOLD for payment 2024-08-07] [$250] Payments - Enable payments modal is dismissed by onboarding modal when new user login via link

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4661829&group_by=cases:section_id&group_order=asc&group_id=229066
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Log out of NewDot
2. Navigate to staging.new.expensify.com/enable-payments
3. Sign in with new gmail account
4. Verify that Onboarding modal appears> Finish the flow

Expected Result:

After completing the onboarding requests user should land on enable-payments page

Actual Result:

Enable payments modal is dismissed by onboarding modal when new user login via link. User navigates to Concierge chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6522853_1719230687197.Recording__3311.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c600605bb01f4797
• Upwork Job ID: 1805389773516765926
• Last Price Increase: 2024-06-24

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[stephanieelliott]

Adding this to #wave-collect since it involves the payment process and onboarding

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c600605bb01f4797

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Enable payments modal is dismissed by onboarding modal when new user login via link. User navigates to Concierge chat

What is the root cause of that problem?

In https://github.com/Expensify/App/blob/main/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx#L73-L78, we navigate to Concierge/system chat page regardless of the route we entered before onboarding modal shows.

So that route will be lost after finishing onboarding.

What changes do you think we should make in order to solve the problem?

In

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx

Line 55 in 698e9c4

Welcome.isOnboardingFlowCompleted({onNotCompleted: () => Navigation.navigate(ROUTES.ONBOARDING_ROOT)});

, add a backTo to indicate the route the user was on before opening the onboarding modal (same pattern in other places in the app).

In

App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Line 72 in 698e9c4

// Otherwise stay on the chats screen.

, if backTo is not a report route/LHN route (or whatever default route it is when the user first logs in without deeplink), do not navigate to Concierge/system chat, as the user deeps link into some other routes and we should preserve that.

What alternative solutions did you explore? (Optional)

We can look at the routes history to see which route is before the onboarding routes, that can be used if backTo is not preferrable.

Also it's ok to not use backTo but just a isFromDeeplink variable should be ok, we'll check if the user was deeplinked in

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx

Line 55 in 698e9c4

Welcome.isOnboardingFlowCompleted({onNotCompleted: () => Navigation.navigate(ROUTES.ONBOARDING_ROOT)});

and just put isFromDeeplink as param when navigating to onboarding screen, if it's true, do not navigate to Concierge/system chat.

[rushatgabhane]

@daledah's proposal LGTM

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[stephanieelliott]

Hey @Gonals just waiting on your go-ahead for the proposal!

[stephanieelliott]

commenting again to remove label

[melvin-bot]

@Gonals, @rushatgabhane, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[stephanieelliott]

Hey @daledah looks like the PR is waiting on you to resolve conflicts

[stephanieelliott]

PR is actively being reviewed.

[stephanieelliott]

PR is awaiting review from @rushatgabhane

[melvin-bot]

This issue has not been updated in over 15 days. @Gonals, @rushatgabhane, @stephanieelliott, @daledah eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[rushatgabhane]

PR on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: add back to after onboarding #44861

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot
• ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1805389773516765926/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

Hey @daledah I extended an offer to you in Upwork -- can you please accept when you have a sec? https://www.upwork.com/nx/wm/offer/103443368

@rushatgabhane can you please complete the BZ checklist?

[daledah]

@stephanieelliott Thanks, I accepted it

[melvin-bot]

@Gonals, @rushatgabhane, @stephanieelliott, @daledah Huh... This is 4 days overdue. Who can take care of this?

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @daledah $250 via Upwork -- PAID
• Contributor+: @rushatgabhane $250 via ND -- please request

Upwork job is here: https://www.upwork.com/jobs/~01c5ddb8f6ccb0f8e7

[JmillsExpensify]

$250 approved for @rushatgabhane