[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Expensify personal - Expensify chat has the option to rename

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Expensify chat
3. Click on the chat header
4. Click Room name
5. Edit the name and save it

Expected Result:

Expensify chat should not have the option to rename

Actual Result:

Expensify chat has the option to rename, but it actually cannot be renamed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6521353_1719047082532.Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify personal - Expensify chat has the option to rename

What is the root cause of that problem?

We use shouldDisableRename function to check if a room can be renamed, we don't take into account System Chats for this

App/src/libs/ReportUtils.ts

Line 6146 in 425804a

function shouldDisableRename(report: OnyxEntry<Report>): boolean {

What changes do you think we should make in order to solve the problem?

We will add a check for ReportUtils.isSystemChat(report) in the shouldDisableRename function here:

App/src/libs/ReportUtils.ts

Lines 6147 to 6157 in 425804a

	if (
	isDefaultRoom(report) ||
	isArchivedRoom(report) ||
	isPublicRoom(report) ||
	isThread(report) ||
	isMoneyRequest(report) ||
	isMoneyRequestReport(report) ||
	isPolicyExpenseChat(report) ||
	isInvoiceRoom(report) ||
	isInvoiceReport(report)
	) {

[mountiny]

Gonna help moving this one forwards to get the checklist into a better place before deployer comes on

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

Using a solution from @neonbhai works well. $50 for helping identify the fix

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Check for system chat report for inability to rename it #44238

If no regressions arise, payment will be issued on 2024-07-02. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@pecanoro / @mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@pecanoro / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@pecanoro / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@pecanoro / @mountiny] Determine if we should create a regression test for this bug.
• [@pecanoro / @mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[pecanoro]

We can simply close this one!

[neonbhai]

@pecanoro hi, I'm eligible for compensation here as noted in #44193 (comment). Please take a look 🙇

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Check for system chat report for inability to rename it #44238

If no regressions arise, payment will be issued on 2024-07-10. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@pecanoro / @mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@pecanoro / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@pecanoro / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@pecanoro / @mountiny] Determine if we should create a regression test for this bug.
• [@pecanoro / @mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

Yes $50 for your help @neonbhai

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[pecanoro]

@anmurali Friendly bump on this: #44193 (comment)

[anmurali]

@neonbhai - here is your offer

[neonbhai]

Thank you, offer accepted!

cc: @anmurali

[anmurali]

Paid.