[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Chat - Suggestion list appears above composer when selecting all text with @ via CMD+A

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.86-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Enter long paragraph until the composer is scrollable
4. Type @ at the end of the paragraph
5. Press CTRL + A

Expected Result:

The suggestion list should appear above the @

Actual Result:

The suggestion list appears above the composer. Sometimes it appears slightly above the composer (with space between the composer and the list)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6519561_1718899495422.20240621_000346.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@aldo-expensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[aldo-expensify]

I think this change came from this PR: #42630

[aldo-expensify]

Maybe the we should close the autocomplete if the user selects text?

Before selecting all:

cursorCoordinates.x 1157
xCoordinatesOfCursor 1552
windowWidth 1728
leftValueForBigScreen 1428

after selecting all:

cursorCoordinates.x 12
xCoordinatesOfCursor 407
windowWidth 1728
leftValueForBigScreen 407

These variables here determine the position of the autocomplete box:

App/src/components/AutoCompleteSuggestions/index.tsx

Lines 75 to 84 in 896c14c

	const xCoordinatesOfCursor = x + cursorCoordinates.x;
	const leftValueForBigScreen =
	xCoordinatesOfCursor + CONST.AUTO_COMPLETE_SUGGESTER.BIG_SCREEN_SUGGESTION_WIDTH > windowWidth
	? windowWidth - CONST.AUTO_COMPLETE_SUGGESTER.BIG_SCREEN_SUGGESTION_WIDTH
	: xCoordinatesOfCursor;
	let bottomValue = windowHeight - y - cursorCoordinates.y + scrollValue - (keyboardHeight || bottomInset);
	const widthValue = isSmallScreenWidth ? width : CONST.AUTO_COMPLETE_SUGGESTER.BIG_SCREEN_SUGGESTION_WIDTH;
	const contentMaxHeight = measureHeightOfSuggestionRows(suggestionsLength, true);

[aldo-expensify]

PR up: #44113

[mountiny]

Per https://expensify.slack.com/archives/C035J5C9FAP/p1718916284226989 we can demote this one, seems minor and Aldo already fixed it but we probably do not need to CP. Thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Disable autocomplete when selecting block #44113

If no regressions arise, payment will be issued on 2024-07-02. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Disable autocomplete when selecting block #44113

If no regressions arise, payment will be issued on 2024-07-10. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[aldo-expensify]

No payment needed (No C+ review or contributor hired)