Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Upgrades] Create Upgrade RHN Panel, Confirmation Panel and connect to upgradeToCorporate action + apply to Report Fields #43916

Closed
garrettmknight opened this issue Jun 18, 2024 · 24 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@garrettmknight
Copy link
Contributor

garrettmknight commented Jun 18, 2024

Part of https://github.com/Expensify/Expensify/issues/391954

Individual steps to complete:

  • Create generic workspace upgrade page with dynamic title / description & icon
  • Create upgrade confirmation page
  • Connect the workspace upgrade page with the upgradeToCorporate policy action
  • Create flow for Report Fields as a feature
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @ishpaul777
@garrettmknight garrettmknight added the Daily KSv2 label Jun 18, 2024
@garrettmknight garrettmknight self-assigned this Jun 18, 2024
@garrettmknight garrettmknight added the NewFeature Something to build that is a new item. label Jun 18, 2024
@garrettmknight garrettmknight moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 18, 2024
Copy link

melvin-bot bot commented Jun 18, 2024

Current assignee @garrettmknight is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 26, 2024
@garrettmknight
Copy link
Contributor Author

Now that Sibtain is back we're back on it here. Currently testing the FE with the BE locally.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Weekly KSv2 labels Jun 27, 2024
@garrettmknight garrettmknight changed the title [Upgrades] Create Upgrade RHN Panel, Confirmation Panel and connect to upgradeToCorporate action [Upgrades] Create Upgrade RHN Panel, Confirmation Panel and connect to upgradeToCorporate action + apply to Report Fields Jul 3, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@garrettmknight
Copy link
Contributor Author

@allroundexperts assigned you a small bug in the flow here

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [Upgrades] Create Upgrade RHN Panel, Confirmation Panel and connect to upgradeToCorporate action + apply to Report Fields [HOLD for payment 2024-07-17] [Upgrades] Create Upgrade RHN Panel, Confirmation Panel and connect to upgradeToCorporate action + apply to Report Fields Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 16, 2024
@garrettmknight garrettmknight added the External Added to denote the issue can be worked on by a contributor label Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Current assignees @allroundexperts and @ishpaul777 are eligible for the External assigner, not assigning anyone new.

@garrettmknight garrettmknight removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jul 18, 2024
@garrettmknight
Copy link
Contributor Author

garrettmknight commented Jul 18, 2024

Payment summary:

@ishpaul777 offer out to you here: https://www.upwork.com/ab/applicants/1813979251771429535/hires?filter=ish&page=1

@ishpaul777
Copy link
Contributor

Thanks for offer @garrettmknight, Would you please put a hold on my payment until 7/22 i'll bump once i am ready to accept Thanks!

@allroundexperts
Copy link
Contributor

@garrettmknight Can we hold my payment as well till we are done with this feature? The first iteration went to staging and we have a few minor bugs to squash. Once everything is good, we can handle the payment.

@melvin-bot melvin-bot bot added the Overdue label Jul 22, 2024
@garrettmknight
Copy link
Contributor Author

Works for me @allroundexperts

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
Copy link

melvin-bot bot commented Jul 22, 2024

Payment Summary

Upwork Job

BugZero Checklist (@garrettmknight)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@garrettmknight
Copy link
Contributor Author

@ishpaul777 awaiting your accepting the offer.

@ishpaul777
Copy link
Contributor

Sorry for delay @garrettmknight, Sadly i'd still have to keep my payment on hold (Expected End of this month) i'll ping once i am ready to accept. Thanks for you patience.

@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels Jul 24, 2024
@garrettmknight
Copy link
Contributor Author

No prob, dropping to weekly. Lemme know when you're ready.

@garrettmknight
Copy link
Contributor Author

Still waiting for payment - @ishpaul777 any update?

@melvin-bot melvin-bot bot added the Overdue label Aug 7, 2024
@ishpaul777
Copy link
Contributor

Will try to get a update tomorrow, otherwise i will take payment. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Aug 7, 2024
@ishpaul777
Copy link
Contributor

Thanks for patience here, please release the payment when you get the chance 🙇 @garrettmknight

@garrettmknight
Copy link
Contributor Author

Yep - paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants