[HOLD for payment 2024-07-10] [$500] [CRITICAL] Open travelDot after accepting terms and conditions

[rushatgabhane]

Booking travel via new dot should take you to travelDot page and authenticate the user

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[twisterdotcom]

Moving this to CRITICAL for GBTA

[rushatgabhane]

PR is here #43966

It fixes quite a few issues 😮‍💨

1. ToS was showing even if it was accepted previously
2. ToS wasn't saved in correct Onyx key
3. Authenticate to travelDot

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[twisterdotcom]

Even though I'm downgrading, I'm happy to keep it at $500. It solves a lot of issues.

[rushatgabhane]

Appreciate it! :)

[rushatgabhane]

PR on staging. It tests well
We can now book travel from newDot 🎉

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [VIP][Travel] Open travelDot after accepting terms and conditions #43966

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @shubham1206agra] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot
• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@twisterdotcom)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[twisterdotcom]

Hello folks, sorry I was OOO last week. I have a bunch to do, I will get them all done today. Thanks for your patience.

[rushatgabhane]

@twisterdotcom could you please confirm payment summary when you can. Thank you : )

[JmillsExpensify]

Reached out via DM

[twisterdotcom]

Payment Summary:

• @rushatgabhane paid $500 via NewDot Requests (Contributor)
• @shubham1206agra paid $500 via Upwork here (C+)

[JmillsExpensify]

$500 approved for @rushatgabhane

[shubham1206agra]

@twisterdotcom Offer accepted

[twisterdotcom]

Paid out.