[HOLD for payment 2024-07-10] [$250] Distance - Map pending not scaled and not fully visible when creating > 1 expenses

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.81-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4613584
Issue reported by: Applause - Internal Team

Issue found when executing PR #39243

Action Performed:

precondition: user a member of a workspace

1. Open the app and log in
2. Open the workspace chat
3. Create more than 1 distance expenses

Expected Result:

"Map pending" text is scaled in the report preview depending on the number of expenses

Actual Result:

"Map pending" is not fully visible, and it is displayed in multiple lines in the report preview.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6508409_1718040300016.video_2024-06-10_13-20-16.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014fbedebd9a7bc999
• Upwork Job ID: 1801433825996987873
• Last Price Increase: 2024-06-14
• Automatic offers:
• ikevin127 | Reviewer | 102816669
• Krishna2323 | Contributor | 102816670

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[luacmartins]

I'm gonna demote this to NAB since it doesn't break anything and is a small issue

[francoisl]

Just compared with production and we used to use a placeholder icon instead of the "Map pending" view:

It sounds like a minor issue coming from #39243, cc @FitseTLT @mollfpr what do you think?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014fbedebd9a7bc999

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[zoro008-svg]

When multiple expenses are created, the map view does not scale appropriately to accommodate all expense entries.

Scaling Adjustment: Implement a dynamic scaling mechanism for the map view based on the number of expenses being created.
Visibility Enhancement: Ensure that all markers or map elements are fully visible and accessible to users without overlapping or clipping.

Implement changes to the map component to resolve scaling and visibility issues.
Conduct thorough testing to verify that the map behaves as expected when creating multiple expenses.
Provide documentation or comments in the codebase explaining the implemented changes

Why I’m a Suitable Candidate:
Problem-Solving Skills: I excel in identifying and resolving frontend issues, ensuring optimal user experience.
Collaborative Approach: I am committed to working closely with Expensify’s team to deliver solutions that meet their requirements and enhance product usability.

I acknowledge the issue and propose to resolve it using the outlined technical approach.
Upon acceptance, I will proceed to post my proposal on Upwork as per Expensify’s guidelines.
Once hired, I will promptly initiate work on implementing the proposed solution and conduct thorough testing to ensure quality and functionality.
By structuring your response in this manner, you demonstrate a clear understanding of the issue, propose a feasible solution, and highlight your qualifications and commitment to addressing Expensify's needs effectively. Adjust the details according to your specific experience and the requirements outlined in the GitHub issue to create a compelling proposal.

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01d227ef6816d3f37c?mp_source=share

[melvin-bot]

📣 @zoro008-svg! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ikevin127]

@zoro008-svg Please make sure you read Contributing to Expensify and once you have a good grasp please format your comment to match the proposal template if you are interested in fixing this issue, otherwise it won't qualify for review.

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[zoro008-svg]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01d227ef6816d3f37c

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@ikevin127, PR ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Android - Map pending text shown in preview instead of icon #44187

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment automatic offer (Reviewer)
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ikevin127]

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR: fix: Android - wrong location briefly shows before San Francisco upon first open of the Distance request page  #27395
• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/27395/files#r1667770691
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition: User is member of a workspace.

1. Open the workspace chat.
2. Create more than 1 distance expenses.
3. Right after creating the distance expense, in report IOU preview -> verify that the pending icon is shown (see reference) as opposed to the map pending text.

Do we agree 👍 or 👎.

[francoisl]

Works for me. Opened an internal issue to create the regression tests – https://github.com/Expensify/Expensify/issues/411499

[ikevin127]

cc @JmillsExpensify Friendly bump for payments!

[greg-schroeder]

@JmillsExpensify I paid this given the contributor pinged about it - I'll file the regression test proposal as well given I am already here.

[JmillsExpensify]

Thanks so much @greg-schroeder