Workspace - "Add" and "Delete" options aren't visible after disconnecting Xero

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

issue found when validating #42620
Version Number: 1.4.78-2
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Log in with a new expensifail account
2. Create a workspace
3. Enable Accounting, Tags, and Taxes from the workspace settings
4. Connect to Xero
5. Disconnect from Xero
6. Navigate to the "Taxes" tab
7. Select a tax
8. Click on the "1 selected" button

Expected Result:

"Add" and "Delete" options should be available.

Actual Result:

"Add" and "Delete" options for Categories, Tags and Taxes are removed when connecting to an accounting integration. The options aren't visible when disconnecting the integration.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6497409_1717155156747.bandicam_2024-05-31_13-24-17-212.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[kavimuru]

We think this bug might be related to #wave-collect - Release 2

[puneetlath]

Since the Xero integration isn't live yet, I don't think we need to treat as a deploy blocker. Let's handle as a normal bug.

[lakchote]

Not a bug, it's because the latest fixes from the merge freeze branches haven't been deployed yet.

cc @trjExpensify

[trjExpensify]

This is fixed in this PR which is merged awaiting a deploy to staging: #42613