[HOLD for payment 2024-06-11] [HOLD for payment 2024-06-06] IOU - Save button is not above keyboard when waypoint input is in focus

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.77-0
Reproducible in staging?: Y
**Reproducible in production?:**N
If this was caught during regression testing, add the test name, ID and link from TestRail: #42464
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Recent destinations list has a few addresses

1. Go to staging.new.expensify.com
2. Go offline
3. Go to FAB > Submit expense > Distance
4. Tap Start
5. Tap on the input
6. Note that Save button does not appear above the keyboard
7. Tap system back button (or swipe) to dismiss the keyboard while the input is still in focus

Expected Result:

In Step 5, Save button will appear above the keyboard (production behavior)
In Step 7, Save button will appear at the bottom when keyboard is dismissed and input is still in focused

Actual Result:

In Step 5, Save button does not appear above the keyboard (production behavior)
In Step 7, Save button is missing at the bottom when keyboard is dismissed and input is still in focused

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6495019_1716981635722.Screen_Recording_20240529_191531_New_Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[arosiclair]

The Start and Stop inputs don't work at all for me 🤨

RPReplay_Final1716991371.MP4

Same thing online or offline.

[trjExpensify]

Yeah, I've got an infinite spinner after entering the waypoints when online.

[trjExpensify]

^^ looks like that might be similar to another deploy blocker reported here and potentially related to this PR.

[arosiclair]

I can reproduce in dev

RPReplay_Final1716998094.MP4

[arosiclair]

Alright this is caused by #35045. Reverting fixes the issue:

RPReplay_Final1716998608.MP4

cc @pac-guerreiro @eVoloshchak @neil-marcellini

[ShridharGoel]

@arosiclair Looks like the submit button is being hidden intentionally.

[arosiclair]

@arosiclair Looks like the submit button is being hidden intentionally.

That's definitely not true. We always show submit buttons above the keyboard.

[ShridharGoel]

Can you check the videos in that PR ?

[ShridharGoel]

@arosiclair #35045 (comment)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[arosiclair]

Revert was merged and CP'd so this is all set

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Revert "Merge pull request #35045 from callstack-internal/issues/30123" #42777

If no regressions arise, payment will be issued on 2024-06-06. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@arosiclair] The PR that introduced the bug has been identified. Link to the PR:
• [@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@arosiclair] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@arosiclair] Determine if we should create a regression test for this bug.
• [@arosiclair] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Revert "Merge pull request #35045 from callstack-internal/issues/30123" #42777

If no regressions arise, payment will be issued on 2024-06-11. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@arosiclair] The PR that introduced the bug has been identified. Link to the PR:
• [@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@arosiclair] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@arosiclair] Determine if we should create a regression test for this bug.
• [@arosiclair] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: