Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HelpDot] LHN clicking navigates to different location #42598

Closed
rushatgabhane opened this issue May 24, 2024 · 11 comments
Closed

[HelpDot] LHN clicking navigates to different location #42598

rushatgabhane opened this issue May 24, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Not a priority Reviewing Has a PR in review Weekly KSv2

Comments

@rushatgabhane
Copy link
Member

rushatgabhane commented May 24, 2024

Coming from:
https://expensify.enterprise.slack.com/archives/C02QSAC6BJ8/p1716512776382679

Clicking LHN links navigates instead of collapsing /expanding the LHN

Issue OwnerCurrent Issue Owner: @rushatgabhane
@rushatgabhane rushatgabhane added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels May 24, 2024
Copy link

melvin-bot bot commented May 24, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 27, 2024

@rushatgabhane, @maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@maddylewis
Copy link
Contributor

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 28, 2024
Copy link

melvin-bot bot commented May 31, 2024

@rushatgabhane, @maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@maddylewis
Copy link
Contributor

will ask for update tomorrow 👍

@rushatgabhane
Copy link
Member Author

rushatgabhane commented Jun 4, 2024

Alright, this is more difficult that i anticipated. We're gonna have to build the navigation menu from scratch.
The existing code works based on the url, but now we're gonna have to handle it in javascript.

Question: when a hub is opened, should it also open the hub in the LHN menu? Or should it have the previous state of LHN before opening the hub

Screen.Recording.2024-06-04.at.12.32.56.mov

@melvin-bot melvin-bot bot removed the Overdue label Jun 4, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

@rushatgabhane @maddylewis this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

@rushatgabhane, @maddylewis Whoops! This issue is 2 days overdue. Let's get this updated quick!

@rushatgabhane
Copy link
Member Author

same update as above ^

@maddylewis
Copy link
Contributor

not a priority rn as the changes require internal engineering resources -- closing

@melvin-bot melvin-bot bot removed the Overdue label Jun 13, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 6, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@NikkiWines NikkiWines removed their assignment Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Not a priority Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants