Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Message "Receipt pending match with credit card." not displayed. #42563

Closed
6 tasks done
lanitochka17 opened this issue May 23, 2024 · 116 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Monthly KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@lanitochka17
Copy link

lanitochka17 commented May 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #40354

Action Performed:

  1. Navigate to staging and login
  2. Create at least 2 Money Request on a single chat
  3. Create a single Money Request on a different chat
  4. Open Money Request

Expected Result:

"Receipt pending match with credit card. Marks as cash to ignore and request payment." should be displayed

Actual Result:

"Receipt pending match with credit card. Marks as cash to ignore and request payment." not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489901_1716498809686.Screen_Recording_2024-05-23_at_16.37.01.mp4
Bug6489901_1716498809668!Screenshot_2024-05-23_at_17 12 43

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016d6d997ccd05eafc
  • Upwork Job ID: 1800481101386428984
  • Last Price Increase: 2024-11-27
  • Automatic offers:
    • dominictb | Contributor | 105181185
Issue OwnerCurrent Issue Owner: @aimane-chnaif
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 23, 2024
Copy link

melvin-bot bot commented May 23, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 27, 2024

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@dylanexpensify
Copy link
Contributor

Sorry will review!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 29, 2024
Copy link

melvin-bot bot commented Jun 3, 2024

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

@dylanexpensify
Copy link
Contributor

Hmm, trying again tday

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

@dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

@dylanexpensify dylanexpensify added the External Added to denote the issue can be worked on by a contributor label Jun 11, 2024
@melvin-bot melvin-bot bot changed the title Message "Receipt pending match with credit card." not displayed. [$250] Message "Receipt pending match with credit card." not displayed. Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~016d6d997ccd05eafc

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 11, 2024
@dylanexpensify
Copy link
Contributor

moved external!

Copy link

melvin-bot bot commented Jun 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@aimane-chnaif
Copy link
Contributor

No proposals yet

@dylanexpensify
Copy link
Contributor

Pending proposals

@slafortune slafortune removed the Daily KSv2 label Oct 31, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2024
@slafortune
Copy link
Contributor

No overdue - waiting on a retest - updated to weekly

@aimane-chnaif
Copy link
Contributor

I am out sick at the moment. Please reassign C+ if this is still reproducible and requires attention.

@dominictb
Copy link
Contributor

@slafortune I can take this over given @aimane-chnaif is OOO.

Copy link

melvin-bot bot commented Nov 6, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@slafortune
Copy link
Contributor

slafortune commented Nov 7, 2024

Once this is retested, I'll look into the assignments.

@kavimuru
Copy link

kavimuru commented Nov 7, 2024

Still able to reproduce

Screen.Recording.2024-11-07.at.16.36.15.mp4

@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 11, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@abekkala
Copy link
Contributor

@aimane-chnaif can you confirm you are back from being out?

@melvin-bot melvin-bot bot added the Overdue label Nov 19, 2024
Copy link

melvin-bot bot commented Nov 20, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@dominictb
Copy link
Contributor

@abekkala @slafortune I can take over this.

Copy link

melvin-bot bot commented Nov 27, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 29, 2024
Copy link

melvin-bot bot commented Nov 29, 2024

This issue has not been updated in over 15 days. @slafortune, @aimane-chnaif eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Overdue labels Nov 29, 2024
@slafortune slafortune assigned dominictb and unassigned aimane-chnaif Dec 3, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 3, 2024
Copy link

melvin-bot bot commented Dec 3, 2024

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@slafortune
Copy link
Contributor

Sorry for the delay @dominictb I've assigned you now.

@slafortune
Copy link
Contributor

@dominictb, what is the status of this? Still reproducible?

@dominictb
Copy link
Contributor

Yes it's still reproducible and we're waiting for proposals.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Jan 15, 2025

@dominictb Could you please share the reproduction steps?

@dominictb
Copy link
Contributor

dominictb commented Jan 16, 2025

After investigating carefully this issue and #40354 conversation history, it turned out that QA misunderstood the reproduction steps. They need to manually mock data for RTER violation to reproduce it. But as deducted from the videos in OP, they misunderstood the mock data step (i.e. they did not do it, from 0:32). So obviously the violation message didn't show in that case.

These steps in this issue OP are just to create sample money requests to mock data:

  1. Create at least 2 Money Request on a single chat
  2. Create a single Money Request on a different chat

I tried to mock the data correctly as mentioned in #40354 OP and it did show the violation message.

@slafortune I believe we can close this issue without any further action.

@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Monthly KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
Status: Done
Development

No branches or pull requests