[HOLD for payment 2024-06-06] [QBO] Fix style regression for the text in ToggleSettingOptionRow

[hayata-suenaga]

#41917 caused style regressions in which several places that use ToggleSettingOptionRow ended up having the text bolded. Fix these bolded text back to the normal style.

Slack convo: https://expensify.slack.com/archives/C01SKUP7QR0/p1715875595366199

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[CortneyOfstad]

Still waiting on a response to this question in the original PR

[hayata-suenaga]

I don't necessarily need an answer for that question. I'll continue with my PR when I have time 🙇

[CortneyOfstad]

No worries and thanks @hayata-suenaga!

[trjExpensify]

If this is an /app PR @hayata-suenaga why not have someone else take it while you work on others? Perhaps, @s77rt?

[s77rt]

I can take this but I don't have access to the Slack conversion linked above.

[trjExpensify]

Here's the short convo:

The PR Hayata references is: #41917

[s77rt]

Got it. On it...

[s77rt]

Raised PR

[parasharrajat]

@trjExpensify @hayata-suenaga Let me know if you don't want the C+ review here as @s77rt requested. #42596 (comment)

I can review asap.

[hayata-suenaga]

I had an ongoing PR... but thank you @s77rt anyway 😄 Let's merge yours

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove style prop from ToggleSettingOptionRow #42596

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Display error messages for Xero Import page #41917
• The offending PR has been commented on: Display error messages for Xero Import page #41917 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No

[CortneyOfstad]

@s77rt I sent you an offer via Upwork here. Let me know once you accept and I'll get that paid ASAP. Thanks!

[s77rt]

@CortneyOfstad Accepted! This needs to be $125 for the regression #42998

[CortneyOfstad]

Good catch, adjusted the payment and completed payment!

Payment Summary

@s77rt — paid $125 via Upwork