-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment + Bonus Aug 18] Change site and app titles to New Expensify #4213
Comments
Triggered auto assignment to @timszot ( |
@timszot Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Triggered auto assignment to @Jag96 ( |
Looks good to me, adding External |
There are 197 references of Expensify.cash in the source. Out of which, I think nearly 150 needs to be changed to New Expensify.
Do you want to change all of that or just the APP names? I can update the IOS app name via xcode. Electron Desktop App name from Code. Android App from Stringx.xml etc. |
@parasharrajat Good eye, I think we'd like to update all of those values as you mentioned, for example here's the last PR we used for renaming this: #975. Job has been posted! |
We can change the IOS app name in Display Name in Project target (General Tab) in xcode |
Proposal My approach would be to use a Grunt script that will internally update the values for the AppName. For example, I've used In addition to this, we can then pull this value from a config/lang file to enable a quick single command update. This will ease out the process in the future. |
Heads up, I am already making some of these changes in #4091. Mostly for copy that is shown to users. |
@parasharrajat your proposal looks good, I've invited you to the Upwork job, if you're interested in this one I'll assign you once accepted. |
@Jag96, @parasharrajat it looks like no one is assigned to work on this job. |
Clearing overdue label, PR is in progress |
Reopening to keep track of payment |
Paid + bonus |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Upwork link: https://www.upwork.com/jobs/~01002fbd8522fb9614
Action Performed:
Expected Result:
Expensify.cash should not be mentioned. New Expensify should be the site title.
Actual Result:
Site title is still Expensify.cash.
Workaround:
None needed.
Platform:
Where is this issue occurring?
Version Number: 1.0.80-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Web:
Android:
Desktop:
Expensify/Expensify Issue URL:
View all open jobs on Upwork
The text was updated successfully, but these errors were encountered: