[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [Details Revamp] Update Policy Expense Report/Requests Name Display Logic

[grgia]

https://docs.google.com/document/d/1-xSZdSZZIuIl0fPO7yypkKfcbWEsnNFAs50ptgL3Gnw/edit#bookmark=id.47hdcwyvv08k

Held on #42071

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[trjExpensify]

Still held.

[cdOut]

Hi, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I'm working on this issue. The PromotedActionsBar has been merged so as far as I know this should be unheld.

[trjExpensify]

Excellent!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Details Revamp] Update ReportDetailsPage for Rooms, Groups, Money Reports and Policy Expenses #43251

If no regressions arise, payment will be issued on 2024-07-02. 🎊

For reference, here are some details about the assignees on this issue:

• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cdOut] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[ikevin127]

@trjExpensify @grgia I require payment as C+ reviewer of PR: #43251 (comment).

Notes:

1. The PR had some regressions, Georgia should be able to confirm this.
2. There are 2 other issues as part of this PR (42074, 42075) where the hold for payment was added as well.

[trjExpensify]

The PR had some regressions, Georgia should be able to confirm this.

@grgia, can you confirm on the regressions so we can move to paying Kevin what's due here?

[ikevin127]

This PR covered multiple app flows and required extensive testing & back-n-forth with the PR author, design team and engineers (see #43251).

Given this I propose a $500 bounty for reviewing this, minus regression penalty if we think that better testing on my part could've prevented all regressions.

🎉 Good work everyone, I think this PR was successful in terms of achieving the requirements while having a farely low regression count given the changes!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ikevin127 paid $250 via Upwork
• Contributor: @cdOut is from an agency-contributor and not due payment

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[ikevin127]

grgia, can you confirm on the regressions so we can move to paying Kevin what's due here?

Bumped on Slack @ https://expensify.slack.com/archives/C01GTK53T8Q/p1720029343489579

I think it's safe to assume there was at least 1 regression here, not sure if more than 1 regressions would factor into the final payment amount. If that's true then we should wait for input, otherwise I think we can move forward with this given that we can't seem to be able to reach grgia on any channel.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Details Revamp] Update ReportDetailsPage for Rooms, Groups, Money Reports and Policy Expenses #43251

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)
• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[trjExpensify]

I think it's safe to assume there was at least 1 regression here, not sure if more than 1 regressions would factor into the final payment amount.

Yeah, each regression counts (guide). That said, I'm happy to move on at $250 with this.

Payment summary above has been updated, and I've sent an offer.

[ikevin127]

@trjExpensify That's fine with me! Offer accepted, thank you!

[trjExpensify]

Paid, closing!