[HOLD for payment 2024-06-11] [$250] [Uneven Splits] [Polish] Android - Split amount input does not animate smoothly

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to FAB > Split expense
3. Enter amount > Next
4. Select a few users > Next

Expected Result:

The amount input with currency will animate smoothly

Actual Result:

The amount input with currency does not animate smoothly. It appears digit by digit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6473648_1715080164660.split_amount_animation.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0166f91b00117784b4
• Upwork Job ID: 1787910960853864448
• Last Price Increase: 2024-05-14
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-split

[dangrous]

this feels front end? There seem to be a ton of split related issues though so there may be investigation already, let me look into it shortly!

[dangrous]

Hm actually, I'm not able to replicate this on local, or on staging - it seems fine to me? Do you mind testing this one more time, when you have a moment? It might have been a temporary thing.

[marcaaron]

This looks pretty minor. Maybe we can just remove the blocker and assign it to @youssef-lr?

[marcaaron]

Seems related to #40386

[youssef-lr]

Yes we were aware of this and decided to work on it past release. We can open this up for contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0166f91b00117784b4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[youssef-lr]

@bernhardoj feel free to raise a PR

[bernhardoj]

PR is ready

cc: @abdulrahuman5196

[CortneyOfstad]

We're in a merge freeze until Wednesday, so this will be delayed 👍

[CortneyOfstad]

Merge freeze is planned to end today 🤞

[marcaaron]

This post has the current merge freeze info. I believe we are still only merging PRs with discretion.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix split amount input does not animate smoothly #42241

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment automatic offer (Reviewer)
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/403911

[CortneyOfstad]

@abdulrahuman5196 can you complete the checklist when you have a chance so there is no delay in payment? Thanks!

[CortneyOfstad]

@abdulrahuman5196 can you please provide an update on the checklist by EOD? Thanks!

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

#40386 (comment)

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open split bill from FAB and enter any amount
2. Select any user participant and press next
3. In the confirm page, verify the split input shows without delay

@CortneyOfstad

[CortneyOfstad]

Payment Summary

@abdulrahuman5196 — paid $250 via Upwork
@bernhardoj — paid $250 via Upwork