Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wave Collect] [Xero] Add translations for sync stages #41486

Closed
lakchote opened this issue May 2, 2024 · 8 comments
Closed

[Wave Collect] [Xero] Add translations for sync stages #41486

lakchote opened this issue May 2, 2024 · 8 comments
Assignees
@pecanoro @lakchote @rushatgabhane
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@lakchote
Copy link
Contributor

lakchote commented May 2, 2024

Problem

Right now, we're displaying confusing Xero sync keys for the sync stages.

It is confusing to the end user.

Solution

Let's translate the Xero sync keys to meaningful sync stages messages.
@lakchote lakchote self-assigned this May 2, 2024
@lakchote lakchote mentioned this issue May 2, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 2, 2024
@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect May 2, 2024
@lakchote lakchote moved this from Release 1: Spring 2024 (May) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 2, 2024
@lakchote lakchote added Daily KSv2 and removed Weekly KSv2 labels May 2, 2024
@trjExpensify
Copy link
Contributor

PR in review

@trjExpensify
Copy link
Contributor

(Make sure to assign the C+ that ends up reviewing this PR)

@trjExpensify
Copy link
Contributor

PR hit staging yesterday.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 16, 2024

@lakchote, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@lakchote
Copy link
Contributor Author

PR is on staging. Waiting for tests to be done.

@lakchote
Copy link
Contributor Author

Assigning @pecanoro as she has helped with reviewing the PR and providing translations.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 24, 2024

@pecanoro, @lakchote, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

@pecanoro
Copy link
Contributor

Closing since this has hit production now and I think we are handling payment separately?

@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pecanoro pecanoro

@lakchote lakchote

@rushatgabhane rushatgabhane

Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
No open projects
[#whatsnext] #wave-collect
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pecanoro @trjExpensify @lakchote @rushatgabhane