[Invoice Rooms] Avatar not matching from InvoiceRoom header to InvoiceRoom invoice preview

[danielrvidal]

If you look at the header on this invoice room and then the avatar on report preview, you can see the C is green in the header and then blue on the invoice preview. I have reproduced this.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[danielrvidal]

Just for reference, it might have something to do with this: #41316

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The background of default avatar is inconsistency

What is the root cause of that problem?

At present, within our application, we create the standard workspace avatar using the policyID to ensure uniformity. But in ReportActionItemSingle Component

App/src/pages/home/report/ReportActionItemSingle.tsx

Line 138 in 729c9ac

id: isWorkspaceActor ? '' : actorAccountID,

If isWorkspaceActor is true, we don't include the policyID, resulting in a different background color for the avatar compared to other instances where the policyID is used to determine the background color.

What changes do you think we should make in order to solve the problem?

App/src/pages/home/report/ReportActionItemSingle.tsx

Line 138 in 729c9ac

id: isWorkspaceActor ? '' : actorAccountID,

We need to pass report.policyID if isWorkspaceActor is true

We also need to address the same issue in the tooltips.

We need to pass accountID={userAccountID} params here

We additionally require updating the type of the accountID props in the UserDetailsTooltip Component to number | string since the policyID might not be exclusively a number. Alternatively, we can introduce new props like avatarID if we prefer not to modify the type of existing props.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Nodebrute]

Regression from #39637

[thesahindia]

Regression from #39637

@rushatgabhane @nkdengineer, can you guys confirm this?

[nkdengineer]

@thesahindia This will be fixed in this PR #41485.

[melvin-bot]

@rushatgabhane, @grgia, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[grgia]

PR still in review

[melvin-bot]

@rushatgabhane, @grgia, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rushatgabhane]

PR merged but not on staging yet

[melvin-bot]

@rushatgabhane, @grgia, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@rushatgabhane, @grgia, @nkdengineer Eep! 4 days overdue now. Issues have feelings too...

[davidcardoza]

I believe this was deployed to production here - #41485 can someone confirm?

[melvin-bot]

@rushatgabhane, @grgia, @nkdengineer Huh... This is 4 days overdue. Who can take care of this?

[rushatgabhane]

Yepp this is in production

[davidcardoza]

Closing this issue out, feel free to reopen if needed @cristipaval