[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] Deeplinking to a whisper results in "hmm it is not here " page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.68-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714415566362469

Action Performed:

1. Copy a link to a whisper in a chat
2. Send it to someone else who doesn't have access to that whisper, but who does have access to the chat.
3. Have that other person click the link

Expected Result:

They should be taken to the report as if they just opened it, and no comment should be linked.

Actual Result:

hmm it's not here page is shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

404.1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MonilBhavsar

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012634f8ccbb4f7594
• Upwork Job ID: 1790412850565140480
• Last Price Increase: 2024-05-22
• Automatic offers:
• tienifr | Contributor | 102448221

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[laurenreidexpensify]

@roryabraham which roadmap project do you think this is linked to?

[melvin-bot]

@laurenreidexpensify Huh... This is 4 days overdue. Who can take care of this?

[laurenreidexpensify]

@roryabraham I haven't made this external yet - can you confirm if you think this is connected to a roadmap project? thanks

[laurenreidexpensify]

@roryabraham bump thanks

[melvin-bot]

@roryabraham, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[roryabraham]

Whoops, sorry for not seeing this earlier. Yes, this is front-end and can be external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012634f8ccbb4f7594

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

@allroundexperts @roryabraham @laurenreidexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[laurenreidexpensify]

Waiting for proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix Deeplinking to a whisper results in hmm it is not here page #42672

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix Deeplinking to a whisper results in hmm it is not here page #42672

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MonilBhavsar]

@allroundexperts mind doing the checklist when you have a moment, please

[laurenreidexpensify]

Payment Summary:

• C+ $500 @allroundexperts requires payment through NewDot Manual Requests
• Contributor $5000 @tienifr paid via Upwork

[laurenreidexpensify]

@MonilBhavsar can you do a me a favour, when @allroundexperts confirms checklist can you please close out and write the regression test (if needed) using this template - https://github.com/Expensify/Expensify/issues/new?assignees=applausebot&labels=QA%2C+Daily%2C+qa-test&projects=&template=AddOrUpdateQATests_TEMPLATE.md&title=QA+-+Add%2FUpdate+test+to+TestRail. I am going parental leave for rest of year tomorrow and seems a bit unnecessary to assign a BZ for that outstanding step. Thanks!

[MonilBhavsar]

Yes of course!

[allroundexperts]

Checklist

1. HIGH: (Comment linking: Step 4) Main "glue" PR for Comment Linking #30269
2. https://github.com/Expensify/App/pull/30269/files#r1650198707
3. N/A
4. A regression test would be helpful. The test steps given in the OP should be sufficient.

[MonilBhavsar]

Issue for creating test case https://github.com/Expensify/Expensify/issues/407098

[JmillsExpensify]

$500 approved for @allroundexperts