[$250] Share code - For split expense, share code is showing E logo in center of QR code.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch app
2. Tap on a report
3. Tap plus icon -- split expense--manual
4. Enter an amount and tap split
5. Open the iou preview
6. Tap on header --- share code

Expected Result:

On split expense, in iou details page, share code must show avatar in center of QR code and must not show E logo.

Actual Result:

On split expense, in iou details page, share code is not showing avatar in center of QR code instead showing E logo.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6454495_1713500832080.split.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d4d48d347af843c9
• Upwork Job ID: 1781311072111943680
• Last Price Increase: 2024-04-19

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@strepanier03 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

20240419_131344.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d4d48d347af843c9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[grgia]

Not a deploy blocker, though I'm not actually sure if this is technically a bug

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Share code - For split expense, share code is showing E logo in center of QR code.

What is the root cause of that problem?

Here we always show the Expensify icon if report exists

What changes do you think we should make in order to solve the problem?

There is no exact information in which cases the Expensify icon should be displayed and in which user avatar. But i suggest to make below changes.

1. Since in there is not enough information whether the current report is split expenses or not we should try to get the required information from parentReportAction. But in this case, paentReportAction is a preview for the previous reportAction and also does not contain this information. And that's why we have to get the previous reportAction from the current report's parrentReportAction to get the information we need.
   To do that we can add below code here. ( We can also move below cod to new function in `ReportUtils.ts )

const parentAction = ReportActionsUtils.getReportAction(report?.parentReportID, report?.parentReportActionID)
const prevActionOfParentAction = ReportActionsUtils.getReportAction(parentAction?.reportID, parentAction?.previousReportActionID)
const isPrevActionOfParentActionSplit = ReportActionsUtils.isSplitBillAction(prevActionOfParentAction)
const shouldDisplayLogo = isReport && parentAction?.actionName !== CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW && !isPrevActionOfParentActionSplit

2. Update this condition as follows: shouldDisplayLogo ?

What alternative solutions did you explore? (Optional)

BE should add needed information in current report and we can use this info in this condition

[dragnoir]

We don't support this feature yet.

The only possible displayed pictures are

• Profile picture
  

  App/src/pages/ShareCodePage.tsx

  Line 88 in a216ee1

  logo={isReport ? expensifyLogo : (UserUtils.getAvatarUrl(currentUserPersonalDetails?.avatar, currentUserPersonalDetails?.accountID) as ImageSourcePropType)}

• Workspace picture
  

  App/src/pages/workspace/WorkspaceProfileSharePage.tsx

  Line 63 in a216ee1

  logo={(policy?.avatar ? policy.avatar : expensifyLogo) as ImageSourcePropType}

In other cases we display only the Expensify logo.

[DmitrievichLevin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

For Split Expense ShareCodeQR is showing E logo.

What is the root cause of that problem?

• ShareCode Logo is determined by boolean isReport
• There are four report types in CONST.ts thus creating ambiguity

What changes do you think we should make in order to solve the problem?

Short-Term:

introduce another bool for whether report === CONST.REPORT.TYPE.IOU

Long-Term:

Encapsulate logo ternary, would move to switch case to handle different report types with the default being expensifyLogo which is scalable.

Demo

ExpensifyDemo.mov

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @DmitrievichLevin! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[DmitrievichLevin]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01b18edd2e975b1033

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[allroundexperts]

Taking over!

[strepanier03]

Confirming some expected behavior here.

[shahinyan11]

Confirming some expected behavior here.

We do not have access to this link

[strepanier03]

We've decided to close this and do nothing, make no changes.