[HOLD for payment 2024-08-02] [$250] Android - Not found page closes prematurely when navigating to invalid WS links

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #36409
Issue reported by: Applause - Internal Team

Action Performed:

1. Open Android app
2. Create a workspace
3. Go to workspace settings page
4. From another app deep link to any of these links:

• https://staging.new.expensify.com/settings/workspaces/kjashdjkashdaks/rateandunit
• https://staging.new.expensify.com/settings/workspaces/kjashdjkashdaks/rateandunit/unit
• https://staging.new.expensify.com/settings/workspaces/kjashdjkashdaks/invite
• https://staging.new.expensify.com/settings/workspaces/kjashdjkashdaks/invite-message

Expected Result:

Not found view should be visible

Actual Result:

Not found view is seen for a second and then closes prematurely navigating to workspace settings page

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453817_1713455686115.Screen_Recording_20240418_184437_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bb3ea96da0ce5340
• Upwork Job ID: 1781079172553498624
• Last Price Increase: 2024-04-18

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bb3ea96da0ce5340

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[neil-marcellini]

I was away for a little bit but I'll start looking more closely now

[neil-marcellini]

Let's see if reverting #36409 fixes the issue. I asked @fedirjh if he can test that since I'm busy with some backend stuff right now. I'll check back in 30 minutes.

[fedirjh]

I am on it right now.

[fedirjh]

I confirm that reverting #36409 fixes the issue.

CleanShot.2024-04-19.at.01.29.01.mp4

[fedirjh]

Revert PR is ready:

• Revert - #36409 "Fix: three not found view" #40526

[neil-marcellini]

@kbecciv or @fedirjh would you please test on Android staging to confirm that the issue is fixed?

[kbecciv]

Checking

[kbecciv]

@neil-marcellini Issue is fixed

Screen_Recording_20240419_222637_New.Expensify.mp4

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[fedirjh]

cc @neil-marcellini I guess this is just pending payment and then it should be closed.

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[fedirjh]

cc @neil-marcellini Could you please assign a BZ member to handle the payment. This is already overdue.

[neil-marcellini]

Ah yes thanks for the reminder

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[twisterdotcom]

Payment Summary:

• @fedirjh paid $250 here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: three not found view v2 #41665

If no regressions arise, payment will be issued on 2024-08-02. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: