-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Web - Scan - Selecting tag via Enter key directly returns to first step of Scan request #40507
Comments
Triggered auto assignment to @tylerkaraszewski ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #wave-collect - Release 1 |
Job added to Upwork: https://www.upwork.com/jobs/~01c1670496416bc0ac |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov ( |
Making this external to get more eyes on this |
The state is getting reset on enter making the user to land on the initial screen , we can look after the function getting triggered on enter keypress and resolve the issue Contributor details |
📣 @combatmaestro! 📣
|
App/src/pages/EditRequestTagPage.js Line 50 in 305f12c
I'd actually make sure that selectTags is being called properly. If at all. And then see what changes afterwards to narrow down the source of the issue. One of the quickest things I'd do? Just check if the focus is being changed for some odd reason at the last minute. Weirder things have happened. Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Closing in favor of #40551 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Expected Result:
App will redirect to Scan confirmation page
Actual Result:
App returns to the first page of Scan expense flow
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6454170_1713467992384.20240419_031512.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: