[$250] Thread - Unable to upload photo for thread avatar from group chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat.
3. Create a group chat.
4. Send a message in the group chat.
5. Right click on the message > Reply in thread.
6. Click on the thread header.
7. Click on the avatar > Upload photo.
8. Upload a photo.

Expected Result:

If thread supports custom avatar, photo should be successfully uploaded. If not, there should not be an option to upload avatar.

Actual Result:

After uploading photo, there is no changes in the thread avatar.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453553_1713442307485.20240418_200817.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017775876faefcb133
• Upwork Job ID: 1781032489627934720
• Last Price Increase: 2024-04-18
• Automatic offers:
• neonbhai | Contributor | 0
• eh2077 | Contributor | 0

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #vip-vsb

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread - Unable to upload photo for thread avatar from group chat

What is the root cause of that problem?

The app doesn't allow us to upload photo for threads in prod.

We don't add an exception for threads when rendering the avatar here here:

App/src/pages/ReportDetailsPage.tsx

Line 230 in a96cc01

const renderAvatar = isGroupChat ? (

What changes do you think we should make in order to solve the problem?

We will had a condition excluding threads here:

const renderAvatar = isGroupChat && !isThread ? (

We may use ReportUtils.isThread for isThread

[marcaaron]

If thread supports custom avatar, photo should be successfully uploaded. If not, there should not be an option to upload avatar.

Threads don't support custom avatars.

This feels like something we should fix.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017775876faefcb133

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[marcaaron]

@neonbhai your solution looks good. Can you get something up soon?

[melvin-bot]

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[marcaaron]

@hayata-suenaga grabbing this from you since it's related to Group Chats.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @sonialiap, @marcaaron, @neonbhai, @eh2077 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[neonbhai]

PR was merged and deployed to prod 3 weeks ago. Friendly bump to finish payments and close the issue

cc: @sonialiap

[sonialiap]

Thanks for the bump. Looks like melvin's automation didn't work here. Reviewing for payment now

[sonialiap]

PR #40563
No regressions

Payment summary

• @neonbhai contributor - paid ✔️
• @eh2077 reviewer $250 - paid ✔️