-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task – Long string appears instead of assignee in system message when assigning task #40413
Comments
Triggered auto assignment to @greg-schroeder ( |
Triggered auto assignment to @nkuoch ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@greg-schroeder I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this issue might be related to the #vip-vsb. |
cc @jasperhuangg or @rlinoz or @thienlnam you might know? |
I'm checking, but maybe this is also related to the cc: @puneetlath |
@rlinoz ExpensiMark is still unaware of application data (accountIDs as well) so I think it won't replace the name in such a way. "key": "reportActions_4663769334777431",
"onyxMethod": "merge",
"value": {
"8945435353820593844": {
"actionName": "TASKEDITED",
"actorAccountID": 14342127,
"avatar": "https:\/\/d1wpcgnaa73g0y.cloudfront.net\/75097e10b068c4e37ad6e6134c6305bb1f828938_128.jpeg",
"created": "2024-04-18 13:58:25.830",
"lastModified": "2024-04-18 13:58:25.830",
"message": [
{
"html": "assigned to <mention-user accountID=14342127><\/mention-user>",
"text": "assigned to @Robert ROBERT robert Kozik KOZIK kozik",
"type": "COMMENT"
}
],
"originalMessage": {
"assignee": "",
"html": "assigned to <mention-user accountID=14342127><\/mention-user>",
"lastModified": "2024-04-18 13:58:25.830"
},
"person": [
{
"text": "Robert ROBERT robert Kozik KOZIK kozik",
"type": "TEXT"
}
],
"previousReportActionID": "9001584629617700205",
"reportActionID": "8945435353820593844",
"shouldShow": false
}
} |
Yeah, git bisect led me to this PR: #40200 |
I can confirm it's from my PR. @abdulrahuman5196 looks like we need to revert the PR and go with my alternative approach. |
I created a revert PR here |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4494366
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
System message appears with user name, when assign task without assignee to me
Actual Result:
System message appears - Assigned to , but not a user name, when assign task without assignee to me
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6453308_1713426139344.Task.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: