[HOLD for payment 2024-04-15] [$125] Tax - App crashes when changing tax rate offline, options not clickable on web&console error

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: No, new feature
Found when executing PR: #33927
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: user is an employee of a collect policy, and tax is enabled OD

1. Open the app and log in as an employee
2. Open the workspace chat
3. Disable internet connection
4. Tap "+" > Request money > Manual
5. Enter the amount and tap next
6. Tap Show more and select a tax rate
7. Request money
8. Open the expense
9. Tap the tax and select a tax rate

Expected Result:

The tax is displayed in the tax field, and the user can select a different one.

Actual Result:

The app crashes after opening the tax rate and selecting a different one. The tax options are not responsive on the web, and there are console errors.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6438748_1712288519367.Recording__374.mp4

Bug6438748_1712288519354.IMG_6193.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013bd787d14b4b4b3e
• Upwork Job ID: 1776216138504876032
• Last Price Increase: 2024-04-15
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• dukenv0307 | Contributor | 0

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@stephanieelliott I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes after opening the tax rate and selecting a different one. The tax options are not responsive on the web, and there are console errors.

What is the root cause of that problem?

policy?.taxRates?.taxes[TransactionUtils.getTaxCode(oldTransaction)] can be undefined

App/src/libs/ReportUtils.ts

Line 2786 in 8fe465d

originalMessage.oldTaxRate = policy?.taxRates?.taxes[TransactionUtils.getTaxCode(oldTransaction)].value;

What changes do you think we should make in order to solve the problem?

Update this line to

        originalMessage.oldTaxRate = policy?.taxRates?.taxes[TransactionUtils.getTaxCode(oldTransaction)]?.value;

What alternative solutions did you explore? (Optional)

NA

[mountiny]

I can help here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013bd787d14b4b4b3e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@dukenv0307 can you please raise the PR promptly? Thank you!

[dukenv0307]

@mountiny Sure. I am working on it now

[mountiny]

The fix is also being covered in this PR #39707 I suggest $125 to @dukenv0307 for help identifying the issue

[MonilBhavsar]

This issue should be fixed!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix crash when tax rate is deleted #39707

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196 / @dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196 / @dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196 / @dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196 / @dukenv0307] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196 / @dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

No C+ required here. Unassigning myself.

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

Awaiting payment @stephanieelliott $125 to @dukenv0307

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: $125 @dukenv0307 PAID via Upwork
• Contributor+: N/A

Upwork job is here: https://www.upwork.com/jobs/~013bd787d14b4b4b3e