Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-15] Fix deploy github action #39581

Closed
Beamanator opened this issue Apr 4, 2024 · 11 comments
Closed

[HOLD for payment 2024-04-15] Fix deploy github action #39581

Beamanator opened this issue Apr 4, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@Beamanator
Copy link
Contributor

Beamanator commented Apr 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1712216796370159

Action Performed:

When @Expensify/mobile-deployers deploy the app in the usual way (see here)

Expected Result:

Prepare production deploy should have run fine like normal

Actual Result:

It failed, see: https://github.com/Expensify/App/actions/runs/8548605498/job/23422579684

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b3d5ebe5dc790d16
  • Upwork Job ID: 1775797869877637120
  • Last Price Increase: 2024-04-04
@Beamanator Beamanator added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Apr 4, 2024
@Beamanator Beamanator self-assigned this Apr 4, 2024
Copy link

melvin-bot bot commented Apr 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b3d5ebe5dc790d16

Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 4, 2024
@Beamanator
Copy link
Contributor Author

Unassigning C+, sorry! Working on this internally, and it's pretty hard / maybe impossible to test locally

@Beamanator Beamanator added Daily KSv2 and removed Weekly KSv2 labels Apr 4, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 4, 2024
@Beamanator
Copy link
Contributor Author

PR merged, will test this via the next deploy soon 🙏

@Beamanator
Copy link
Contributor Author

success! closing!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot changed the title Fix deploy github action [HOLD for payment 2024-04-15] Fix deploy github action Apr 8, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-15. 🎊

Copy link

melvin-bot bot commented Apr 8, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
  • [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@Beamanator] Determine if we should create a regression test for this bug.
  • [@Beamanator] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@Beamanator
Copy link
Contributor Author

no payment needed here, closing

@Beamanator Beamanator reopened this Apr 8, 2024
@Beamanator
Copy link
Contributor Author

oops i thought this was reopened on accident lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants