Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Violations - Pending Receipts] Create a ReportActionItemBasicMessage component for the DISMISSEDVIOLATION and MERGEDWITHCASHTRANSACTION actions #39540

Closed
yuwenmemon opened this issue Apr 3, 2024 · 10 comments
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Apr 3, 2024

Design Doc: https://docs.google.com/document/d/1zJqlTe_RajuBtfQYvbMx8PpXgA9CEnUGVyuqZihQ-ok/edit
Tracking GH: https://github.com/Expensify/Expensify/issues/372206

HOLD ON https://github.com/Expensify/Expensify/issues/385026


We'll create a ReportActionItemBasicMessage component for the DISMISSEDVIOLATION and MERGEDWITHCASHTRANSACTION messages in renderItemContent in ReportActionItem.tsx. This is so that we can properly render the system message in the front end.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cb054d6db46b169e
  • Upwork Job ID: 1783663567300743168
  • Last Price Increase: 2024-04-26
@yuwenmemon yuwenmemon added Engineering Weekly KSv2 NewFeature Something to build that is a new item. labels Apr 3, 2024
Copy link

melvin-bot bot commented Apr 3, 2024

Copy link

melvin-bot bot commented Apr 3, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@yuwenmemon yuwenmemon changed the title [HOLD][Violations - Pending Receipts] Create a ReportActionItemBasicMessage component for the DISMISSEDVIOLATION action [HOLD][Violations - Pending Receipts] Create a ReportActionItemBasicMessage component for the DISMISSEDVIOLATION and MERGEDWITHCASHTRANSACTION actions Apr 3, 2024
@JmillsExpensify JmillsExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #expense Apr 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@muttmuure
Copy link
Contributor

@yuwenmemon is there an order of priority for this? Is it going to be picked up in the next week or two?

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2024
@yuwenmemon
Copy link
Contributor Author

Yeah it's held on https://github.com/Expensify/Expensify/issues/385026 which will probably only be ready in a week or two.

@yuwenmemon yuwenmemon self-assigned this Apr 26, 2024
@yuwenmemon yuwenmemon added the Internal Requires API changes or must be handled by Expensify staff label Apr 26, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01cb054d6db46b169e

@yuwenmemon yuwenmemon changed the title [HOLD][Violations - Pending Receipts] Create a ReportActionItemBasicMessage component for the DISMISSEDVIOLATION and MERGEDWITHCASHTRANSACTION actions [Violations - Pending Receipts] Create a ReportActionItemBasicMessage component for the DISMISSEDVIOLATION and MERGEDWITHCASHTRANSACTION actions Apr 26, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

@yuwenmemon
Copy link
Contributor Author

Handling this internally.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 26, 2024
@JmillsExpensify
Copy link

PR up for re-review

@muttmuure
Copy link
Contributor

Looks like we're good to close?

@yuwenmemon
Copy link
Contributor Author

Yep!

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #expense May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants