Add better testing coverage for comment linking

[roryabraham]

@perunt this issue is a placeholder to implement a bunch of UI tests to cover comment linking functionality

[perunt]

Currently, we have one end-to-end test for opening a link in another chat. I have a few ideas for these tests:

1. Open a link from Chat A to Chat B if messages are preloaded in Onyx.
   2-3. Open a link from Chat A to Chat B if messages are preloaded in Onyx and located on the edge of preloading. This will help us know if we properly trigger fetch more and if the focus on the linked message is preserved. Also, do the same for the opposite side.
2. Open a link from Chat A to Chat B for an image message.
3. Open a link from Chat A to Chat B for a thread.
4. Open a link from Chat A to Chat B for a message with a reaction

[roryabraham]

@perunt any update here?

[roryabraham]

@perunt is OOO, definitely hoping that we complete this before he jumps into anything else though

[roryabraham]

pretty sure @perunt will be back from vacation and able to work on this soon

[roryabraham]

@perunt I'm looking at doing a significant refactor of comment linking - this is a very important issue to work on to provide better stability for this core feature

[roryabraham]

Saw some partial updates here from @janicduplessis last week: https://expensify.slack.com/archives/C05LX9D6E07/p1715895921197829?thread_ts=1714656403.682529&cid=C05LX9D6E07

[janicduplessis]

I have some extra unit tests for getContinuousReportActionChain to cover some edge cases around inserting random actions. I have a few more cases in mind too that I want to add.

After that it would be great to add some UI tests to have more complete test coverage of comment linking flows.

[melvin-bot]

This issue has not been updated in over 15 days. @roryabraham, @perunt eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[perunt]

Not overdue, I just started working on it. I'ill push some tests soon

[roryabraham]

@janicduplessis has been working on UI tests in the new client-side gap detection PR

[perunt]

Is it still needed in the E2E tests?
Also, do we have a list of issues related to comment linking? I just want to check if my finding has already been captured

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] E2E test. Linking, same page  #44286

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @perunt does not require payment (Contractor)

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[roryabraham]

This is done