Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] Chat - Emoji tab opens at lower level, Change default skin tone not accessible for an attachment #39195

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 28, 2024 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Go to any chat - 1:1 DM, #admins room
  3. Tap on + icon in composer >> select add attachment >> upload attachment
  4. Hover over attachment & select add reaction option from action menu
  5. Scroll down the emoji panel

Expected Result:

Emoji tab should open at the top level, so that "Change default skin tone" option in emoji panel should be accessible in 100% zoom for an attachment when selecting the add reaction option from action menu

Actual Result:

  1. Emoji tab opens at the same level as the attachment message & hence "Change default skin tone" option in emoji panel not accessible in 100% zoom for an attachment when selecting the add reaction option from action menu
    Also, some of the flag emojis not accessible as well
  2. Issue happens for an attachment saved just above the composer field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6430381_1711641233117.Recording__110.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 28, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@lanitochka17
Copy link
Author

@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

Production:

Recording.111.mp4

@francoisl
Copy link
Contributor

I can repro on staging but not in dev, I think this is already fixed. I see 2 new PRs that modified the emoji popover got merged but are not on staging yet, figuring out which one fixes it and will request a CP.

@francoisl
Copy link
Contributor

Ok yeah, pretty sure #39143 fixes this. There's already a CP running for it, I'll test again when it's deployed.

@francoisl
Copy link
Contributor

Confirmed fixed on staging now.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Mar 28, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Mar 29, 2024
@melvin-bot melvin-bot bot changed the title Chat - Emoji tab opens at lower level, Change default skin tone not accessible for an attachment [HOLD for payment 2024-04-05] Chat - Emoji tab opens at lower level, Change default skin tone not accessible for an attachment Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-05. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 2, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-04-05] Chat - Emoji tab opens at lower level, Change default skin tone not accessible for an attachment [HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] Chat - Emoji tab opens at lower level, Change default skin tone not accessible for an attachment Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-09. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants