Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simplified Collect][Taxes] - "Hmm it's not here" error appears briefly when opening taxes tab again #39154

Closed
2 of 6 tasks
izarutskaya opened this issue Mar 28, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.57.2
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #38375
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. OD: Log in with a new expensifail account
  2. OD: Create a collect workspace with chat enabled
  3. ND: Log in with the same admin account
  4. ND: Go offline
  5. ND: Navigate to Workspace settings - More features
  6. ND: Enable taxes
  7. ND: Navigate to Workspace settings - More features - Taxes
  8. ND: Go online and wait for the taxes to turn white
  9. ND: Naviate tack to Workspace settings
  10. ND: Open taxes again

Expected Result:

There shouldn't be any errors.

Actual Result:

"Hmm it's not here" error appears briefly when opening taxes tab again.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6429228_1711572625996.az_recorder_20240327_211437.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@izarutskaya
Copy link
Author

@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@izarutskaya
Copy link
Author

Production

bandicam.2024-03-28.15-22-06-372.mp4

@MonilBhavsar
Copy link
Contributor

Commented on the offending PR

@luacmartins
Copy link
Contributor

I'm unable to reproduce this

Screen.Recording.2024-03-28.at.8.44.46.AM.mov

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 28, 2024
@luacmartins luacmartins changed the title Workspace - "Hmm it's not here" error appears briefly when opening taxes tab again [Simplified Collect][Taxes] - "Hmm it's not here" error appears briefly when opening taxes tab again Mar 28, 2024
@luacmartins
Copy link
Contributor

Either way, I dont think this is a blocker since the functionality still works.

@rojiphil
Copy link
Contributor

I also tried reproducing this issue but could not. Here is an attached test video.
Also, the BE is saving the default rates. Further, the default tax rates can be seen in OD also. So, the functionality works.
Considering that we are unable to reproduce, I think it may be better to ask QA to reproduce this again.

39154-mweb-chrome.mp4

@luacmartins luacmartins added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Mar 28, 2024
@MonilBhavsar MonilBhavsar added Weekly KSv2 and removed Daily KSv2 labels Mar 29, 2024
@trjExpensify
Copy link
Contributor

@izarutskaya are you able to reproduce this?

@alexpensify
Copy link
Contributor

Today, I tested in Chrome and did not get the Hmm notice mentioned here. I can successfully land on the Tax page after going back from the Workspace tab.

2024-04-03_14-34-42

I'm going to suggest we close this GH and reopen if this is reproducible again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants