Taxes - Inconsistency in leading 0 in saving tax rate

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #38733

Action Performed:

Precondition:

• User is admin of Collect workspace

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces > Collect workspace
3. Go to Taxes > Add rate > Value
4. Enter 01 and save it
5. Click Value again
6. Note that 0 is preserved
7. Click on any existing tax rate
8. Click Value > Enter 01 > Save
9. Click Value again
10. Note that 0 is not preserved

Expected Result:

There should be consistency whether leading 0 in tax rate should be preserved

Actual Result:

In Step 5, 0 is preserved in adding tax rate flow
In Step 9, 0 is not preserved in edit existing tax rate flow

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6428827_1711552910550.20240327_231650.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Taxes - Inconsistency in leading 0 in saving tax rate

What is the root cause of that problem?

Here In the AmountSelectorModal we are directly passing the value from the props to useSate and so this code only works while the component is mounted . And and when the props value is updated, the currentValue will not be updated accordingly. And the thing is that the value of the props is updated differently ( see here ) than the currentValue of the state ( see here )

What changes do you think we should make in order to solve the problem?

Add below code here

useEffect(()=>{
    setValue(value)
}, [value])

What alternative solutions did you explore? (Optional)

Add new handleAmountChange function in AmountSelectorModal component which will update the value in the same way as it is done while pressing save here. And use it instead setValue

const handleAmountChange =(val: string)=>{
    setValue(String(Number(val)))
}

What alternative solutions did you explore? (Optional)

Remove this line and use value from props everywhere instead currentValue

[dylanexpensify]

reviewing now!

[dylanexpensify]

Could not repro, and low value

[shahinyan11]

@dylanexpensify It still reproducible

Screen.Recording.2024-04-03.at.00.43.57.mov