[$500] 'Hmm its not here' displayed when refreshing expensify classic page #38865

lanitochka17 · 2024-03-23T13:44:47Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #37955

Action Performed:

Navigate to Settings - Switch to Expensify Classic
Choose any option
Click on the Next button
Verify input is auto-focused
Now refresh page

Expected Result:

'Hmm its not here' should not be displayed when refreshing expensify classic page

Actual Result:

'Hmm its not here' displayed when refreshing expensify classic page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6423438_1711128399760.2024-03-22_22-16-14.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c71608c41784a351
Upwork Job ID: 1772068230275534848
Last Price Increase: 2024-03-25
Automatic offers:

hoangzinh | Reviewer | 0
GandalfGwaihir | Contributor | 0

Issue Owner

Current Issue Owner: @adelekennedy

melvin-bot · 2024-03-23T13:44:59Z

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

lanitochka17 · 2024-03-23T13:45:25Z

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

ZhenjaHorbach · 2024-03-23T14:59:39Z

I think this should be fixed in this PR
#38856

allgandalf · 2024-03-23T15:10:26Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The real problem here is that the back screen central pane gets to the chats window and doesn't stay on settings page

What is the root cause of that problem?

We do not map the Switch to expensify screen to Central Pane:

App/src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts

Lines 4 to 22 in 2003844

    
           const CENTRAL_PANE_TO_RHP_MAPPING: Partial<Record<CentralPaneName, string[]>> = { 
        
               [SCREENS.SETTINGS.PROFILE.ROOT]: [ 
        
                   SCREENS.SETTINGS.PROFILE.DISPLAY_NAME, 
        
                   SCREENS.SETTINGS.PROFILE.CONTACT_METHODS, 
        
                   SCREENS.SETTINGS.PROFILE.CONTACT_METHOD_DETAILS, 
        
                   SCREENS.SETTINGS.PROFILE.NEW_CONTACT_METHOD, 
        
                   SCREENS.SETTINGS.PROFILE.STATUS_CLEAR_AFTER, 
        
                   SCREENS.SETTINGS.PROFILE.STATUS_CLEAR_AFTER_DATE, 
        
                   SCREENS.SETTINGS.PROFILE.STATUS_CLEAR_AFTER_TIME, 
        
                   SCREENS.SETTINGS.PROFILE.STATUS, 
        
                   SCREENS.SETTINGS.PROFILE.PRONOUNS, 
        
                   SCREENS.SETTINGS.PROFILE.TIMEZONE, 
        
                   SCREENS.SETTINGS.PROFILE.TIMEZONE_SELECT, 
        
                   SCREENS.SETTINGS.PROFILE.LEGAL_NAME, 
        
                   SCREENS.SETTINGS.PROFILE.DATE_OF_BIRTH, 
        
                   SCREENS.SETTINGS.PROFILE.ADDRESS, 
        
                   SCREENS.SETTINGS.PROFILE.ADDRESS_COUNTRY, 
        
                   SCREENS.SETTINGS.SHARE_CODE, 
        
               ],

What changes do you think we should make in order to solve the problem?

Add the Screen SCREENS.SETTINGS.EXIT_SURVEY.REASON to the CENTRAL_PANE_TO_RHP_MAPPING and this issue will be solved

Also add subpages:

App/src/libs/Navigation/linkingConfig/config.ts

Lines 350 to 359 in 2003844

    
           }, 
        
           [SCREENS.SETTINGS.EXIT_SURVEY.REASON]: { 
        
               path: ROUTES.SETTINGS_EXIT_SURVEY_REASON, 
        
           }, 
        
           [SCREENS.SETTINGS.EXIT_SURVEY.RESPONSE]: { 
        
               path: ROUTES.SETTINGS_EXIT_SURVEY_RESPONSE.route, 
        
           }, 
        
           [SCREENS.SETTINGS.EXIT_SURVEY.CONFIRM]: { 
        
               path: ROUTES.SETTINGS_EXIT_SURVEY_CONFIRM.route, 
        
           },

What alternative solutions did you explore? (Optional)

N/A

allgandalf · 2024-03-23T15:11:07Z

Note

@adelekennedy , the real bug is actually different over here, can you please check the video, the Central Pane changes on refresh

ishpaul777 · 2024-03-24T20:39:39Z

i dont think this is related to #38856, here issue is the background page is not persisting after the refresh which is what we should fix by adding these routes to CENTRAL_PANE_TO_RHP_MAPPING(@GandalfGwaihir's proposal)

ZhenjaHorbach · 2024-03-24T21:21:48Z

@ishpaul777
There are 2 different problems here
First related with the background page

Second with 'Hmm its not here' (which relevant for Report screen when any RHP page is open) and I think this should be fixed in #38856

For example :

Screen.Recording.2024-03-24.at.22.19.13.mov

allgandalf · 2024-03-24T21:55:03Z

@ZhenjaHorbach , I checked over here, if we implement my proposal we don't have this problem as now we have mapped the Central Pane to RHP, thanks :)

Video:

simplescreenrecorder-2024-03-25_03.27.23.mp4

c.c. @adelekennedy

ishpaul777 · 2024-03-24T22:06:45Z

@ZhenjaHorbach good catch, i understand issue now. i think we can fix that in that PR.

allgandalf · 2024-03-24T22:08:59Z

@ZhenjaHorbach good catch, i understand issue, i think we can fix that in that PR.

Yes @ishpaul777 , that issue for will surely get fixed in #38856 as it happens mostly for report pages, but we need to address the current bug which we found in this issue :)

melvin-bot · 2024-03-25T01:09:26Z

Job added to Upwork: https://www.upwork.com/jobs/~01c71608c41784a351

melvin-bot · 2024-03-25T01:09:31Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

roryabraham · 2024-03-25T01:10:59Z

updated #38856, this will be partially fixed by it. You'll no longer see Hmmm its not here but you will still see the account settings change to a report on refresh, which is unexpected. More changes would also be needed to fix this the rest of the way. Making this external

roryabraham · 2024-03-25T01:13:33Z

assigning myself since this appears to be a bug in the exit survey, which I built. @GandalfGwaihir's proposal LGTM and tests well 👍🏼

melvin-bot · 2024-03-25T01:13:51Z

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-03-25T01:13:59Z

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

allgandalf · 2024-03-25T02:56:55Z

PR ready for review @hoangzinh :)

c.c. @roryabraham

roryabraham · 2024-04-12T18:04:20Z

PR was merged through some mysterious GitHub anomaly - there was no internal GH approver and @MonilBhavsar claims he did not merge the PR 😕

Anyways, there was an bug reported on the PR, but I think it was fixed in #38856.

So I want to do some extra testing but I think we're done here, pending payments

roryabraham · 2024-04-12T18:06:02Z

That bug is still reproducible, but it's separate from this one. We can proceed with payment here since this is fixed

allgandalf · 2024-04-12T18:06:54Z

Thanks :)

adelekennedy · 2024-04-12T18:16:00Z

Payment sent!

roryabraham · 2024-04-15T20:35:21Z

reported bug the other bug: https://expensify.slack.com/archives/C049HHMV9SM/p1713213269308389

allgandalf · 2024-04-15T21:02:38Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

hmm not here is displayed on refresh on exit survey page page

What is the root cause of that problem?

When we display hmm not here page we are only checking for the current state immediately after refresh, the useNetwork gives the value of isOffline true for the first time, we never check if the content is loading.

What changes do you think we should make in order to solve the problem?

Subscribe to the ONYXKEYS.IS_SWITCHING_TO_OLD_DOT key by variable isLoading like we have already subscribed for the one of the exit survey page:

App/src/pages/settings/ExitSurvey/ExitSurveyConfirmPage.tsx

Lines 111 to 113 in a7820d2

    
           isLoading: { 
        
               key: ONYXKEYS.IS_SWITCHING_TO_OLD_DOT, 
        
           },

Similarly subscribe in other two pages and update the offline condition check below;

App/src/pages/settings/ExitSurvey/ExitSurveyConfirmPage.tsx

Line 68 in a7820d2

{isOffline && <ExitSurveyOffline />}

To:

{isOffline && isLoading && <ExitSurveyOffline />}

Result video

Screen.Recording.2024-04-16.at.2.15.43.AM.mov

allgandalf · 2024-04-15T21:03:29Z

reported bug the other bug: https://expensify.slack.com/archives/C049HHMV9SM/p1713213269308389

@roryabraham as the issue was discovered during the PR, can I have a dibs on the proposal whenever that issue comes out? I have a proposal ready as you can see above :) ?

roryabraham · 2024-04-15T21:47:33Z

Posted a link to your proposal in the slack thread where the bug was reported

allgandalf · 2024-06-03T19:34:13Z

@roryabraham , due to weird behaviour we faced from github during the #38907, the linked PR was never put on staging nor production, the PR was only merged in Main, can you CP it to staging please ?

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 23, 2024

melvin-bot bot assigned adelekennedy Mar 23, 2024

ZhenjaHorbach mentioned this issue Mar 23, 2024

Don't show 404 on ReportScreen if isLoading is true #38856

Merged

49 tasks

roryabraham added the External Added to denote the issue can be worked on by a contributor label Mar 25, 2024

melvin-bot bot changed the title ~~'Hmm its not here' displayed when refreshing expensify classic page~~ [$500] 'Hmm its not here' displayed when refreshing expensify classic page Mar 25, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 25, 2024

melvin-bot bot assigned hoangzinh Mar 25, 2024

roryabraham self-assigned this Mar 25, 2024

roryabraham assigned allgandalf Mar 25, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 25, 2024

allgandalf mentioned this issue Mar 25, 2024

[Fix]: Central Pane changes when refreshing expensify classic page #38907

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels Mar 25, 2024

melvin-bot bot added the Weekly KSv2 label Mar 25, 2024

roryabraham added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Apr 12, 2024

roryabraham added Daily KSv2 and removed Weekly KSv2 labels Apr 12, 2024

adelekennedy closed this as completed Apr 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$500] 'Hmm its not here' displayed when refreshing expensify classic page #38865

[$500] 'Hmm its not here' displayed when refreshing expensify classic page #38865

lanitochka17 commented Mar 23, 2024 •

edited by roryabraham

Loading

melvin-bot bot commented Mar 23, 2024

lanitochka17 commented Mar 23, 2024

ZhenjaHorbach commented Mar 23, 2024

allgandalf commented Mar 23, 2024 •

edited

Loading

allgandalf commented Mar 23, 2024

ishpaul777 commented Mar 24, 2024

ZhenjaHorbach commented Mar 24, 2024 •

edited

Loading

allgandalf commented Mar 24, 2024 •

edited

Loading

ishpaul777 commented Mar 24, 2024 •

edited

Loading

allgandalf commented Mar 24, 2024

melvin-bot bot commented Mar 25, 2024

melvin-bot bot commented Mar 25, 2024

roryabraham commented Mar 25, 2024

roryabraham commented Mar 25, 2024

melvin-bot bot commented Mar 25, 2024

melvin-bot bot commented Mar 25, 2024

allgandalf commented Mar 25, 2024

roryabraham commented Apr 12, 2024 •

edited

Loading

roryabraham commented Apr 12, 2024

allgandalf commented Apr 12, 2024

adelekennedy commented Apr 12, 2024

roryabraham commented Apr 15, 2024

allgandalf commented Apr 15, 2024

allgandalf commented Apr 15, 2024 •

edited

Loading

roryabraham commented Apr 15, 2024

allgandalf commented Jun 3, 2024

[$500] 'Hmm its not here' displayed when refreshing expensify classic page #38865

[$500] 'Hmm its not here' displayed when refreshing expensify classic page #38865

Comments

lanitochka17 commented Mar 23, 2024 • edited by roryabraham Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Mar 23, 2024

lanitochka17 commented Mar 23, 2024

ZhenjaHorbach commented Mar 23, 2024

allgandalf commented Mar 23, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

allgandalf commented Mar 23, 2024

ishpaul777 commented Mar 24, 2024

ZhenjaHorbach commented Mar 24, 2024 • edited Loading

allgandalf commented Mar 24, 2024 • edited Loading

ishpaul777 commented Mar 24, 2024 • edited Loading

allgandalf commented Mar 24, 2024

melvin-bot bot commented Mar 25, 2024

melvin-bot bot commented Mar 25, 2024

roryabraham commented Mar 25, 2024

roryabraham commented Mar 25, 2024

melvin-bot bot commented Mar 25, 2024

melvin-bot bot commented Mar 25, 2024

allgandalf commented Mar 25, 2024

roryabraham commented Apr 12, 2024 • edited Loading

roryabraham commented Apr 12, 2024

allgandalf commented Apr 12, 2024

adelekennedy commented Apr 12, 2024

roryabraham commented Apr 15, 2024

allgandalf commented Apr 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

allgandalf commented Apr 15, 2024 • edited Loading

roryabraham commented Apr 15, 2024

allgandalf commented Jun 3, 2024

lanitochka17 commented Mar 23, 2024 •

edited by roryabraham

Loading

allgandalf commented Mar 23, 2024 •

edited

Loading

ZhenjaHorbach commented Mar 24, 2024 •

edited

Loading

allgandalf commented Mar 24, 2024 •

edited

Loading

ishpaul777 commented Mar 24, 2024 •

edited

Loading

roryabraham commented Apr 12, 2024 •

edited

Loading

allgandalf commented Apr 15, 2024 •

edited

Loading