[HOLD for payment 2024-04-05] HIGH: [Performance] Send less user is typing events

[iwiznia]

Reported https://expensify.slack.com/archives/C049HHMV9SM/p1710969968937119

We seem to be sending the UserIsTyping message for every keystroke. This means if I'm in a DM with you, and if I'm typing quickly, I am sending you a continuous stream of messages via Pusher -- which is hammering your client's network stack, Onyx database, and main thread. I think we should ideally:

• Send the first message the moment you start typing
• Send a new message every second, so long as you are still typing

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014119b0bde30a6fc4
• Upwork Job ID: 1770576924726861824
• Last Price Increase: 2024-03-20

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014119b0bde30a6fc4

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[quinthar]

Incidentally, I think we are sending typing indicators even after we leave the room. Do we explicitly leave the channel of past rooms when leaving the room, or not?

[iwiznia]

Yes, we are doing that here

[quinthar]

Actually it looks like we don't reliably unsubscribe from isTyping events -- it could be that we unsubscribe when switching to another room, but we might not unsubscribe when switching to a non-room page (eg, Settings)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Ensure we send the typing indicator as soon as you type and once ever… #38716

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @eVoloshchak owed $500 via NewDot

BugZero Checklist (@muttmuure)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1770576924726861824/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[iwiznia]

@muttmuure you handling this?

[muttmuure]

@eVoloshchak ready for you to submit a request in New Expensify

[eVoloshchak]

@muttmuure, not sure if I'm missing something, shouldn't this be $500 since this is
a) HIGH
b) was created before April 5th?

According to https://expensify.slack.com/archives/C02NK2DQWUX/p1712250884549319

[muttmuure]

Updated to $500 thanks!

[JmillsExpensify]

$500 approved for @eVoloshchak