Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-03] [$500] [Simplified Collect][Tags] Implement bulk actions for tags #38635

Closed
luacmartins opened this issue Mar 19, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Waiting for copy User facing verbiage needs polishing Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Mar 19, 2024

Implement bulk actions for tags - https://docs.google.com/document/d/1X0dIhQO4fb4fdZcFGCNFUtzMUSvNHnPKIB9lR_8KDUI/edit#bookmark=kix.5j6sapl0i6p2

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018f6eaaffcd630659
  • Upwork Job ID: 1770225917816684544
  • Last Price Increase: 2024-03-19
Issue OwnerCurrent Issue Owner: @slafortune
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 19, 2024
@luacmartins luacmartins self-assigned this Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@luacmartins luacmartins moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 19, 2024
@luacmartins luacmartins added the NewFeature Something to build that is a new item. label Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Current assignee @slafortune is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 19, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Mar 19, 2024
@allroundexperts
Copy link
Contributor

Translation verification required for the following:

English

enableTags: 'Enable tags',
disableTag: 'Disable tag',
disableTags: 'Disable tags',
deleteTags: 'Delete tags',
deleteTagsConfirmation: 'Are you sure that you want to delete these tags?',

Spanish

  enableTags: 'Habilitar etiquetas',
  disableTag: 'Desactivar etiqueta',
  disableTags: 'Desactivar etiquetas',
  deleteTags: 'Eliminar etiquetas',
  deleteTagsConfirmation: '¿Estás seguro de que quieres eliminar estas etiquetas?',

Similar translations for categories

deleteCategoryPrompt: '¿Estás seguro de que quieres eliminar esta categoría?',
disableCategories: 'Desactivar categorías',
disableCategory: 'Desactivar categoría',
enableCategories: 'Activar categorías',
enableCategory: 'Activar categoría',
deleteFailureMessage: 'Se ha producido un error al intentar eliminar la categoría. Por favor, inténtalo más tarde.',
categoryName: 'Nombre de la categoría',

Screenshots
Screenshot 2024-03-20 at 1 31 55 AM

Screenshot 2024-03-20 at 1 32 03 AM

Screenshot 2024-03-20 at 1 32 09 AM

Screenshot 2024-03-20 at 1 32 25 AM

@mountiny mountiny added the Waiting for copy User facing verbiage needs polishing label Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Triggered auto assignment to @shmaxey (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

@mountiny
Copy link
Contributor

Hello @shmaxey can you please help us confirm the copy from marketing perspective. Thank you

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 19, 2024
@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~018f6eaaffcd630659

@melvin-bot melvin-bot bot changed the title [Simplified Collect][Tags] Implement bulk actions for tags [$500] [Simplified Collect][Tags] Implement bulk actions for tags Mar 19, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Current assignees @allroundexperts and @ishpaul777 are eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 19, 2024
@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 19, 2024
@shmaxey
Copy link
Contributor

shmaxey commented Mar 19, 2024

On the [English] confirmation prompts, we should say "Are you sure that you want to delete these tags?" and "Are you sure that you want to delete this tag?"

Otherwise, looks good!

@iammudassirali
Copy link

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem we aim to address in this issue is the absence of bulk actions functionality for tags in Simplified Collect. Currently, users are unable to perform actions like editing or deleting multiple tags simultaneously, leading to inefficiencies and increased manual effort.

What is the root cause of that problem?

The root cause of this problem lies in the lack of a feature that allows users to select and apply actions to multiple tags at once.

What changes do you think we should make in order to solve the problem?

To solve this issue, we should implement bulk actions functionality, enabling users to manage tags more efficiently and streamline their workflow. By adding options to edit, delete, or apply changes to multiple tags simultaneously, we can significantly enhance the user experience and improve productivity.

What alternative solutions did you explore? (Optional)

Alternative solutions explored include manual tag management and implementing individual actions for each tag, but these approaches are time-consuming and inefficient. Implementing bulk actions provides a more user-friendly and scalable solution to address this issue effectively.

I look forward to discussing this proposal further and collaborating on its implementation.

Best regards,
Mudassir Ali

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Mar 27, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Simplified Collect][Tags] Implement bulk actions for tags [HOLD for payment 2024-04-03] [$500] [Simplified Collect][Tags] Implement bulk actions for tags Mar 27, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 27, 2024
Copy link

melvin-bot bot commented Mar 27, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 27, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.56-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-03. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 27, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@allroundexperts / @ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@mountiny
Copy link
Contributor

$500 for @ishpaul777 and for @allroundexperts

@slafortune
Copy link
Contributor

@mountiny @allroundexperts I believe no regression tests are needed, can you confirm?

@mountiny
Copy link
Contributor

mountiny commented Apr 2, 2024

Yeah I think these will be handled in a separate issue for Simplified collect test cases

@slafortune
Copy link
Contributor

@ishpaul777 Offer sent here
@allroundexperts to be paid via NewDot - $500

@slafortune
Copy link
Contributor

@ishpaul777 I would guess you want this payment held still based on this when do you anticipate this being complete?

@ishpaul777
Copy link
Contributor

Accepting offer! Thanks for holding

@slafortune
Copy link
Contributor

@allroundexperts to be paid via NewDot - $500

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Apr 4, 2024
@JmillsExpensify
Copy link

$500 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Waiting for copy User facing verbiage needs polishing Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

8 participants