Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Deleted bank account appears if you add a new after disconnecting #38598

Closed
2 of 6 tasks
kbecciv opened this issue Mar 19, 2024 · 6 comments
Closed
2 of 6 tasks
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.54.0
Reproducible in staging?: y
Reproducible in production?: can not check prod
Issue found when executing PR: #36495
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in with a new expensifail account
  2. Create a workspace
  3. Navigate to the Workspace settings - Reimbursements - Connect bank account
  4. Fully add a Plaid Chase bank, stop at the "You're all set" step
  5. Tap on the "Disconnect bank account" button
  6. Start adding Plaid Regions bank

Expected Result:

I should be able to add a new bank account

Actual Result:

Deleted bank account appears after the "Choose an account" step, if you add a new after disconnecting.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418988_1710839737606.WYIF9534.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 19, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 19, 2024

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Mar 19, 2024

We think that this bug might be related to #wave-collect - Release 1

@amyevans
Copy link
Contributor

Looks like it's coming from #36495, @mateuuszzzzz could you take a look please? cc @mountiny @aimane-chnaif

@aimane-chnaif
Copy link
Contributor

@amyevans did you confirm that this is not reproducible after reverting PR locally?

Reproducible in production?: can not check prod

Not able to check if this happens on production

@amyevans
Copy link
Contributor

Okay yeah good call, thanks. The same is experienced with the PR reverted locally:

revert-local.mov

I believe it's just a limitation of our dev/staging credentials setup so I'm going to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants