[HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [$250] Desktop/Web - User Status - Unable to enter a custom time for user status using the keyboard

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.54-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4435149
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com with Safari/Chrome or open Desktop App
2. Login with any account
3. Tap to User > Settings
4. Tap to Status icon and select any emoji and Message
5. Tap to "Clear After"
6. Select "Custom"
7. Select "Time"
8. Enter new custom time using the keyboard

Expected Result:

User can enter new custom time for user status using the keyboard

Actual Result:

Unable to enter a custom time for user status using the keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418465_1710801239438.Desktop-Status-Unable-enter-custom-time-keyboard.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@youssef-lr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to enter a custom time for user status using the keyboard

What is the root cause of that problem?

We're using maxLength={2} for hour input and minute input, and the value is formatted with fixed size (2) so when user try to edit the hour/minute, onChangeAmount function is not called since the input length is already reached to limit (2)

What changes do you think we should make in order to solve the problem?

We should remove maxLength in both hour and minute input since we already have the logic to format the value to fixed size (2)

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2024-03-19.at.22.54.29.mov

[youssef-lr]

I think we need to find the offending PR first. I'm on it.

[youssef-lr]

This is coming from this PR as it started passing all props to AmountTextInput when in the past we weren't actually passing maxLength to AmountTextInput. @tienifr looks good to me.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[youssef-lr]

@tienifr are you available to work on the PR now?

[youssef-lr]

@tienifr I'll be working on the PR myself to unblock the deploy, you'll still be eligible for the payment here. Thank you!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove prop that's not needed #38646

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

• @tienifr requires payment (Needs manual offer from BZ)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove prop that's not needed #38646

If no regressions arise, payment will be issued on 2024-03-29. 🎊

For reference, here are some details about the assignees on this issue:

• @tienifr requires payment (Needs manual offer from BZ)

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[youssef-lr]

@puneetlath can we issue a $250 payment to @tienifr please?

[puneetlath]

Offer is here: https://www.upwork.com/nx/wm/offer/101723112

@tienifr please ping me on the issue when you've accepted.

[tienifr]

@tienifr please ping me on the issue when you've accepted.

@puneetlath I accepted, thanks!

[puneetlath]

Paid. Thanks everyone!