[Simplified Collect][Distance Rates] Distance rates - Enter key does not save distance rate

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.54-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #38035
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is an admin of Collect workspace.

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Distance rates.
4. Click Add rate.
5. Enter amount.
6. Hit Enter.

Expected Result:

Enter key will save the rate.

Actual Result:

Nothing happens when hitting Enter key on Add rate page.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418210_1710787211296.20240319_023638.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-control

[Krishna2323]

Offending PR: #38035

cc: @luacmartins

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Enter key does not save distance rate

What is the root cause of that problem?

We don't pass disablePressOnEnter and it's default value is set to true

App/src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx

Lines 69 to 79 in 4f2ec61

	<FormProvider
	formID={ONYXKEYS.FORMS.POLICY_CREATE_DISTANCE_RATE_FORM}
	submitButtonText={translate('common.save')}
	onSubmit={submit}
	validate={validate}
	enabledWhenOffline
	style={[styles.flexGrow1]}
	shouldHideFixErrorsAlert
	submitFlexEnabled={false}
	submitButtonStyles={[styles.mh5, styles.mt0]}
	>

What changes do you think we should make in order to solve the problem?

pass disablePressOnEnter=false in FormProvider.

What alternative solutions did you explore? (Optional)

N/A

[luacmartins]

This was introduced in #38035 and it's not a blocker since it only affects collect policies in NewDot. We can address this in a follow up PR cc @MrMuzyk

[ArekChr]

Hey @luacmartins, I'm available to handle this issue, please assign me

[luacmartins]

Closing this one since we already merged a fix via another PR.