[HOLD for payment 2024-03-26] [HIGH] [$500] [Mentions] Cannot confirm mention via clicking or hitting the enter key

[dylanexpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.51-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dylanexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1710448753252709

Action Performed:

1. Head to any room
2. Thread any comment in the room
3. Mention any user in the thread who hasn't commented in it

Expected Result:

The mention is selected, auto-filled, and the hover menu disappears

Actual Result:

The mention flickers and doesn't complete. On prod, it updates the handle, but still flickers and doesn't complete.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-03-14.at.8.35.15.PM.mov

Screen.Recording.2024-03-14.at.8.47.14.PM.mov

Screen.Recording.2024-03-14.at.8.42.43.PM.mov

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01072b12ec0438630b
• Upwork Job ID: 1768384067744870400
• Last Price Increase: 2024-03-14
• Automatic offers:
• getusha | Contributor | 0

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01072b12ec0438630b

[melvin-bot]

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

[situchan]

This looks quite similar to #32280.
Not sure @koko57's PR might cover this case as well.

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[quinthar]

Let's definitely do a root cause analysis to figure out where this regression came from, and how it slipped through our testing.

[quinthar]

@getusha can you give an ETA for when you'll be able to fix this?

[getusha]

@quinthar will review the PR in 2 hours #38361

[allroundexperts]

Let's definitely do a root cause analysis to figure out where this regression came from, and how it slipped through our testing.

This came up when we added the shortened private domain mentions feature. In our code here, we had a condition that kept on calculating mention suggestions when the mention text (with a space) was same as the display text. This was always true because the mention code was always different from the user's display text. With the implementation of the above feature, there were cases where the display name became equal to the mention code. This resulted in an endless loop for the calculation of suggestion items which resulted in this bug.

[mountiny]

Merged the fix

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: allow suggestion menu to close once a mention is chosen #38361

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @getusha requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts / @getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts / @getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts / @getusha] Determine if we should create a regression test for this bug.
• [@allroundexperts / @getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[getusha]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @getusha] The PR that introduced the bug has been identified. Link to the PR: Drop domain names when searching for users and auto-filling mentions #36697
• [@allroundexperts / @getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: already known Drop domain names when searching for users and auto-filling mentions #36697 (comment)
• [@allroundexperts / @getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1712060439904009
• [@allroundexperts / @getusha] Determine if we should create a regression test for this bug. Yes
• [@allroundexperts / @getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open any room/dm
2. Make sure you're signed in with private domain email not @gmail.com or any other public provider.
3. Open a thread from any message in the chat
4. Mention any user (has to be from same private domain)
5. Highlight the result and hit enter
6. Verify that the mention is inserted and the popup is closed
7. Repeat step 4 and press/tap on the result
8. Verify that the mention is inserted and the popup is closed

Do we agree 👍 or 👎

[bfitzexpensify]

Payment summary:

@getusha to be paid $500 for contributor work - paid via Upwork ✅
@allroundexperts to be paid $500 for C+ work - to be made via manual request

Regression steps proposed in https://github.com/Expensify/Expensify/issues/388157.

We're all done here, thanks everyone.

[JmillsExpensify]

$500 approved for @allroundexperts