Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split - Split button is smaller than the split button on production #38351

Closed
3 of 6 tasks
kbecciv opened this issue Mar 14, 2024 · 8 comments
Closed
3 of 6 tasks

Split - Split button is smaller than the split button on production #38351

kbecciv opened this issue Mar 14, 2024 · 8 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Mar 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.52-3
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by:

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Go to FAB > Request money > Manual.
  3. Enter amount > Next.

Expected Result:

The split button will not be smaller than the button on production.

Actual Result:

The split button is smaller than the button on production. On Android and iOS app, when the font size is minimum, the button is even smaller.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6414025_1710444490757.web.mp4

image

image

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 14, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 14, 2024

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Mar 14, 2024

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

@luacmartins
Copy link
Contributor

This was already fixed by this CP #38275. Confirmed that's solved in staging on the latest build. Closing.

@kbecciv
Copy link
Author

kbecciv commented Mar 14, 2024

@luacmartins The issue is still reproducible on version 1.4.52-3. I'm attempting to identify which build has resolved the issue in CP.

@luacmartins
Copy link
Contributor

Oh I see that they are 4px smaller on staging.

Staging
Screenshot 2024-03-14 at 1 54 26 PM

Production
Screenshot 2024-03-14 at 1 54 39 PM

@Expensify/design can you confirm the correct size for these?

Either way, I don't think this is a blocker.

@luacmartins luacmartins reopened this Mar 14, 2024
@luacmartins luacmartins added Daily KSv2 and removed Hourly KSv2 labels Mar 14, 2024
@dannymcclain
Copy link
Contributor

The left/right padding should be 12px, so the Staging one is the right size (first screenshot in your comment).

CleanShot 2024-03-14 at 15 17 14@2x

@luacmartins
Copy link
Contributor

Awesome, thank you so much for confirming! Seems like we're good to close here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants