Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave Collect] [More Features] Update the NewDot enable tax feature call #38138

Closed
mountiny opened this issue Mar 12, 2024 · 4 comments
Closed
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Mar 12, 2024

Problem

When the taxes are enabled in OldDot, 2 API calls are done, where one sets the taxes as enabled and the other one creates the default tax rates for the policy.

This is against the 1:1:1 idea for NewDot API calls.

Solution

Update the NewDot enabled tax API call such that the default tax rates are created if they do not exist yet

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011ccf8461ae334ba0
  • Upwork Job ID: 1767555727223484416
  • Last Price Increase: 2024-03-12
@mountiny mountiny added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011ccf8461ae334ba0

Copy link

melvin-bot bot commented Mar 12, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @shubham1206agra (Internal)

@mountiny mountiny moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 12, 2024
@mountiny mountiny changed the title [More Features] Update the NewDot enable tax feature call [Wave Collect] [More Features] Update the NewDot enable tax feature call Mar 12, 2024
@luacmartins
Copy link
Contributor

Oh I realized this other issue is a duplicate. We already got a contributor working on that one and I also have this draft PR. I'm gonna close this one in favor of #38234

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants