[HOLD for payment 2024-03-26] [$500] Clicking back from "settings" opens the chat roport correctly but the LHN does not updated in resized window

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.50-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709954156595959

Action Performed:

1. Go to any chat on Desktop
2. Open the inspector (to squish the main pane)
3. Click Settings
4. Then click the < button in the main pane settings header

Note that the main pane switches back to your chat
Note that the LHN doesn't switch to show the chat

Expected Result:

Both chat report page and LHN updates correctly

Actual Result:

Note that the main pane switches back to your chat
Note that the LHN doesn't switch to show the chat

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2834.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0102df661b992fc6ab
• Upwork Job ID: 1768017543522787328
• Last Price Increase: 2024-03-13

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[apeyada]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking back from "settings" opens the chat roport correctly but the LHN does not updated in resized window

What is the root cause of that problem?

App/src/pages/workspace/WorkspacesListPage.tsx

Line 350 in 77375e8

shouldShowBackButton={isLessThanMediumScreen}

App/src/pages/workspace/WorkspacesListPage.tsx

Line 389 in 77375e8

shouldShowBackButton={isLessThanMediumScreen}

Here, the condition of showing back button is wrong. It's true even if it's isMediumScreenWidth

What changes do you think we should make in order to solve the problem?

Update above conditions to isSmallScreenWidth

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0102df661b992fc6ab

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[abzokhattab]

i think this is related to this PR #37525 (comment)

[shubham1206agra]

This is a regression from #37525. It might be intentional.
cc @narefyev91 @rushatgabhane @luacmartins

[Pujan92]

Yes, it is related to #37525 and I don't think it is intentional and seems the condition was updated mistakenly. Let @narefyev91 confirm.

[narefyev91]

Hey - yup making window to break earlier to mobile size - is intentional, but back button can be used at later break point. Will fix that

[Pujan92]

@johncschuster Can you plz assign @rushatgabhane here as they are handling the review of the regression fix PR.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix visibility of back button in Workspaces #38278

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

Payment Summary:

C+: @rushatgabhane - $500 to be paid via Manual Request

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Invite user to workspace via invite link #37525

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37525/files#r1540046598

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[JmillsExpensify]

$500 approved for @rushatgabhane based on summary.