Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android-Required label appears when create request even People must tag expenses is disabled #37645

Closed
2 of 6 tasks
lanitochka17 opened this issue Mar 1, 2024 · 6 comments
Closed
2 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.46-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • User is an employee of Collect workspace on Old Dot
  • "People must tag expenses" option is disabled by Admin
  1. As employee navigate to Workspace chat> +> Request money> Manual
  2. Add amount> Click Next
  3. Take a note of Final confirmation page

Expected Result:

Since Admin has disable "People must tag expenses" option - Employee should not see Required label on Tag section

Actual Result:

"Required" label is present on Tag section when Employee create request, even "People must tag expenses" is disabled by admin

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6398808_1709326849415.Recording__2450.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 1, 2024

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave6
CC @greg-schroeder

@francoisl
Copy link
Contributor

I'm unable to repro, I'm thinking it might have been a delayed notification being sent to the Android client after you disabled the tag requirement in the workspace on OldDot. The code for that page also hasn't changed in a while.

gh37645.mov

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Mar 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@francoisl
Copy link
Contributor

Can't repro on v1.4.47-6 either, closing for now.

@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants