Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Not able to update the desktop version from the deprecated version #37349

Closed
1 of 6 tasks
m-natarajan opened this issue Feb 27, 2024 · 27 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Feb 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.40-4
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709019010145459

Action Performed:

  1. Have a deprecated version of the desktop app (such as 1.4.40-4) installed.
  2. Get a screen to update the app version "Please update to the latest version of New Expensify"
  3. Click update

Expected result:

the app downloads the update, then automatically restarts and updates.

Actual result:

It downloads the .dmg for a new version of the app. To use this version, the user would have to fully uninstall the existing app version and reinstall it from the dmg, Meanwhile, the normal upgrade path of clicking New Expensify -> Check for updates in the app menu is broken. It relies on browser notifications, which have been disabled. (edited)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (4)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0137e8a469dcace76d
  • Upwork Job ID: 1813344678361465062
  • Last Price Increase: 2024-08-22
Issue OwnerCurrent Issue Owner: @roryabraham
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@roryabraham
Copy link
Contributor

Putting this on HOLD for #36758 to make it possible for Applause to test this.

@roryabraham roryabraham changed the title Not able to update the desktop version from the deprecated version [HOLD] Not able to update the desktop version from the deprecated version Feb 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
@adelekennedy adelekennedy changed the title [HOLD] Not able to update the desktop version from the deprecated version [HOLD for 36758] Not able to update the desktop version from the deprecated version Mar 1, 2024
@adelekennedy
Copy link

on hold

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 1, 2024
@adelekennedy
Copy link

@roryabraham this is still on hold for #36758 right? I think we'd deprioritize this till weekly or monthly to match that issue?

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@adelekennedy adelekennedy added Weekly KSv2 and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 4, 2024
@roryabraham
Copy link
Contributor

agreed

@melvin-bot melvin-bot bot added the Overdue label Mar 12, 2024
@adelekennedy adelekennedy added Monthly KSv2 and removed Weekly KSv2 labels Mar 13, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2024
@adelekennedy
Copy link

deprioritized at the moment

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@adelekennedy
Copy link

This is an improvement tied to #36758 - keeping monthly and on hold for now

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@melvin-bot melvin-bot bot added the Overdue label May 16, 2024
@adelekennedy
Copy link

still deprioritized

@melvin-bot melvin-bot bot removed the Overdue label May 16, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 16, 2024
@rayane-d
Copy link
Contributor

Waiting on proposals

@roryabraham roryabraham changed the title [$250] Not able to update the desktop version from the deprecated version [$500] Not able to update the desktop version from the deprecated version Jul 19, 2024
Copy link

melvin-bot bot commented Jul 19, 2024

Upwork job price has been updated to $500

@rayane-d
Copy link
Contributor

A useful resource for anyone who wants to post a proposal:
https://expensify.slack.com/archives/C01GTK53T8Q/p1721427447896089

@roryabraham
Copy link
Contributor

As discussed in slack, we unfortunately have to put this on HOLD until 9.0.8-1 is deprecated

@roryabraham roryabraham changed the title [$500] Not able to update the desktop version from the deprecated version [HOLD][$500] Not able to update the desktop version from the deprecated version Jul 23, 2024
@roryabraham roryabraham self-assigned this Jul 23, 2024
Copy link

melvin-bot bot commented Jul 26, 2024

@roryabraham, @adelekennedy, @rayane-djouah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2024
@rayane-d
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 26, 2024
@roryabraham
Copy link
Contributor

Can check in here to see when this can come off HOLD. Right now the minimum supported version is 9.0.5-13

@roryabraham roryabraham added Weekly KSv2 and removed Daily KSv2 labels Jul 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 5, 2024
@adelekennedy
Copy link

@roryabraham what's the minimum supported version we need in order to take this off hold? Do we need to wait until it's current?

@roryabraham
Copy link
Contributor

roryabraham commented Aug 8, 2024

we need to wait for https://github.com/Expensify/Web-Expensify/blob/3f944d3b34597a71007af529093ac9170c269167/lib/Request.php#L31 to show 9.0.8-2 or higher.

Of course, if we don't want to wait, we could just deprecate 9.0.8-1 (though, I'd at minimum wait until next week, because of the earnings call)

@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 16, 2024
@roryabraham
Copy link
Contributor

PR to deprecate 9.0.8-1: https://github.com/Expensify/Web-Expensify/pull/43217

time to move this along

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2024
@rayane-d
Copy link
Contributor

@AndrewGable @roryabraham Why this was closed?

@roryabraham roryabraham reopened this Aug 21, 2024
@roryabraham roryabraham changed the title [HOLD][$500] Not able to update the desktop version from the deprecated version [$500] Not able to update the desktop version from the deprecated version Aug 21, 2024
Copy link

melvin-bot bot commented Aug 22, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@rayane-d
Copy link
Contributor

Bumped #expensify-open-source https://expensify.slack.com/archives/C01GTK53T8Q/p1724804687546469

@roryabraham
Copy link
Contributor

Just completed a successful (forced) update. Going to close this as no longer reproducible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants