-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-22] [$250] [TS migration] Migrate VideoPlayerContexts
component files to TypeScript
#36724
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01981a2129abb4828c |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak ( |
Dibs |
Would like to work on it. |
dips |
I can work on it |
ProposalUpdate the Video player component to type script following the style guide. Please re-state the problem that we are trying to solve in this issue.We want uniform language throughout the app. What is the root cause of that problem?Files are not in type script What changes do you think we should make in order to solve the problem?Change them to typescript What alternative solutions did you explore? (Optional)Maybe changing them to blazor. |
I am Koustubh, a full stack developer. I’d like to work on this job. |
Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this issue. |
I don't have any other TS migration assigned so would like to work on this ticket |
Hey @hayata-suenaga, I'm leaving the Expensify-SWM team for now and @smelaa will handle this task. |
Hello! I'm Aleksandra Smela from Software Mansion, the expert agency and I would like to work on this issue. |
📣 @smelaa! 📣
|
The BZ member will need to manually hire smelaa for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future! |
@eVoloshchak, @hayata-suenaga, @smelaa Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
The BZ member will need to manually hire smelaa for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future! No need to hire smelaa. They're from Software Mansion, one of the expert agencies. |
@eVoloshchak, @hayata-suenaga, @smelaa Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@smelaa please mark the PR ready for review once it's ready 🙇 |
Triggered auto assignment to @bfitzexpensify ( |
needs payment for @eVoloshchak who is a C+ who reviewed the TypeScript migration PR. The PR author is an expert agency engineer and no need for payment |
VideoPlayerContexts
component files to TypeScriptVideoPlayerContexts
component files to TypeScript
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-22. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment summary: @eVoloshchak to be paid $250 via manual request |
$250 approved for @eVoloshchak. |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files related to the
VideoPlayerContexts
componentUpwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: