Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hold for payment 2024-04-17] [$250] [TS migration] Migrate VideoPlayer component files to TypeScript #36722

Closed
hayata-suenaga opened this issue Feb 16, 2024 · 31 comments
Closed

[hold for payment 2024-04-17] [$250] [TS migration] Migrate VideoPlayer component files to TypeScript #36722

hayata-suenaga opened this issue Feb 16, 2024 · 31 comments
Assignees
@jjcoffee @joekaufmanexpensify @hayata-suenaga @smelaa
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Feb 16, 2024 •
edited by melvin-bot bot
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files related to VideoPlayer component

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017f4d6dc2e2fed5bb
  • Upwork Job ID: 1758559462761594880
  • Last Price Increase: 2024-02-16
  • Automatic offers:
    • jjcoffee | Reviewer | 0
@hayata-suenaga hayata-suenaga added External Added to denote the issue can be worked on by a contributor Daily KSv2 Typescript Migration labels Feb 16, 2024
@hayata-suenaga hayata-suenaga self-assigned this Feb 16, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017f4d6dc2e2fed5bb

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 16, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@hayata-suenaga hayata-suenaga mentioned this issue Feb 16, 2024
Closed
@muas19
Copy link

muas19 commented Feb 16, 2024

Would like to work on it

@rayane-d
Copy link
Contributor

I would like to work on this

@ghost
Copy link

ghost commented Feb 16, 2024

Dibs

@Koustubh-lapate
Copy link

I am Koustubh, a full stack developer. I’d like to work on this job.

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@kowczarz
Copy link
Contributor

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this issue.

@jjcoffee
Copy link
Contributor

@hayata-suenaga Do I need to select a contributor here or are these ones for agencies?

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 19, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 19, 2024

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@hayata-suenaga
Copy link
Contributor Author

@jjcoffee @kowczarz is going to work on this 👍

@kowczarz
Copy link
Contributor

Hey, I'm leaving the Expensify-SWM team for now and @smelaa will handle this task.

@smelaa
Copy link
Contributor

smelaa commented Feb 20, 2024

Hello! I'm Aleksandra Smela from Software Mansion, the expert agency and I would like to work on this issue.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 20, 2024

📣 @smelaa! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@smelaa
Copy link
Contributor

smelaa commented Feb 20, 2024

Contributor details
Your Expensify account email: [email protected]

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 20, 2024

The BZ member will need to manually hire smelaa for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
@hayata-suenaga
Copy link
Contributor Author

the PR is still in draft.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 7, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 11, 2024

@jjcoffee, @hayata-suenaga, @smelaa Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hayata-suenaga
Copy link
Contributor Author

the PR is still in draft.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 11, 2024
@hayata-suenaga
Copy link
Contributor Author

the PR is still in draft.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 13, 2024
@hayata-suenaga
Copy link
Contributor Author

the PR is still in draft.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 18, 2024
@hayata-suenaga
Copy link
Contributor Author

The PR is still in draft

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Mar 26, 2024
@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Apr 4, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@joekaufmanexpensify
Copy link
Contributor

PR deployed to prod. Any payment is due in 2 days (2024-04-17)

@joekaufmanexpensify joekaufmanexpensify changed the title [$250] [TS migration] Migrate VideoPlayer component files to TypeScript [hold for payment 2024-04-17] [$250] [TS migration] Migrate VideoPlayer component files to TypeScript Apr 15, 2024
@joekaufmanexpensify joekaufmanexpensify added Daily KSv2 and removed Weekly KSv2 labels Apr 18, 2024
@joekaufmanexpensify
Copy link
Contributor

Only payment here is $250 to @jjcoffee for C+ review via upwork

@joekaufmanexpensify
Copy link
Contributor

@jjcoffee $250 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

All set. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjcoffee jjcoffee

@joekaufmanexpensify joekaufmanexpensify

@hayata-suenaga hayata-suenaga

@smelaa smelaa

Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
8 participants
@muas19 @jjcoffee @joekaufmanexpensify @Koustubh-lapate @rayane-d @kowczarz @hayata-suenaga @smelaa