Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Entering certain diacritics such as à, á, â in the composer is broken (iOS Simulator) #36203

Closed
1 of 6 tasks
m-natarajan opened this issue Feb 9, 2024 · 34 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Feb 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.39-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @francoisl
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707435603099939

Action Performed:

  1. Open any chat
  2. In the composer, type Option+`, then a

Expected result:

à is entered in the composer

Actual result:

`a is entered in the chat
Same goes with Option+e , then letter, e.g. ´a is entered instead of á

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011af575af2fe9ca45
  • Upwork Job ID: 1755783765816233984
  • Last Price Increase: 2024-02-16
@m-natarajan m-natarajan added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 9, 2024
@melvin-bot melvin-bot bot changed the title Entering certain diacritics such as à, á, â in the composer is broken [$500] Entering certain diacritics such as à, á, â in the composer is broken Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011af575af2fe9ca45

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Copy link

melvin-bot bot commented Feb 9, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@ikevin127
Copy link
Contributor

👋 As a native romanian I can confirm that these diacritic characters work if pasted / written directly in the composer using native keyboard (or native keyboard shortcut extensions):

Screenshot 2024-02-09 at 14 35 29

I never encountered any apps in which I had to write a certain combination of characters which then were parsed to my native diacritics like: ă, â, î, ș, ț, french ones like à, è, ù, or german ones: ä, ö, ü, ß.

If we're expecting character combinations like ´a to be parsed as á then I think that would be a new feature, though a pretty confusing one 👀 since there are so many language diacritics that would have to come up w/ character combinations for.

Unless this used to work at a certain point (by design) and it doesn't work anymore.

@francoisl
Copy link
Contributor

written directly in the composer using native keyboard

Ah yes I think that's the difference, I'm using a Macbook with a US English keyboard, which doesn't have any keys with accents.

To clarify, this is not an Expensify-specific feature, it's a native way to enter accents on MacOS, and so far I haven't seen any app where this didn't work.

The other way is to long-press on a key like a, and it opens a small modal with the variations of the letter you can choose from, but I don't think anyone in their right mind uses that regularly 😄

image

@francoisl
Copy link
Contributor

Btw, forgot to mention but this is most likely due to #35837.

@jeremy-croff
Copy link
Contributor

Btw, forgot to mention but this is most likely due to #35837.

Cannot reproduce anymore, I believe that was the culprit and had been reverted.

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
@tomekzaw
Copy link
Contributor

A similar issue also occurs on iOS simulator. The diacritics are correctly applied but the leading backtick is not removed.

Using RNTextInput (without Live Markdown Preview):

RNTextInput.mov

Using MarkdownTextInput (with Live Markdown Preview):

MarkdownTextInput.mov

@tomekzaw
Copy link
Contributor

This issue is reproducible in Live Markdown example app, reported as Expensify/react-native-live-markdown#181.

Copy link

melvin-bot bot commented Feb 12, 2024

@sobitneupane, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

@greg-schroeder
Copy link
Contributor

Okay - should we create a new issue or just change this one to focus on the iOS case?

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@tomekzaw
Copy link
Contributor

The behavior on native iOS will be fixed in Expensify/react-native-live-markdown#182.

@francoisl
Copy link
Contributor

@tomekzaw to clarify, will that PR only fix native iOS? Cause the issue was also happening on web & desktop. Either way it's fine, we can keep this issue open to remember to also fix other platforms.

@tomekzaw
Copy link
Contributor

@francoisl That's correct, this PR only fixes native iOS. We're still investigating the issue on web.

@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
@greg-schroeder
Copy link
Contributor

Cause the issue was also happening on web & desktop. Either way it's fine, we can keep this issue open to remember to also fix other platforms.

All right - but I thought web was fixed by the revert of #35837? @francoisl

@melvin-bot melvin-bot bot removed the Overdue label Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

@sobitneupane, @greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 26, 2024
Copy link

melvin-bot bot commented Mar 1, 2024

@tomekzaw @greg-schroeder @thienlnam this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Copy link

melvin-bot bot commented Mar 1, 2024

@tomekzaw, @greg-schroeder, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@greg-schroeder
Copy link
Contributor

Thoughts on a timeline for this one @tomekzaw? Just want to make sure I'm on the same page <3

@melvin-bot melvin-bot bot removed the Overdue label Mar 2, 2024
@tomekzaw
Copy link
Contributor

tomekzaw commented Mar 2, 2024

@greg-schroeder Since this issue happens only on iOS simulators, we decided to deprioritize this and focus on the analogous issue happening on web first. Once we fix it for web, I will continue working on this issue.

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

@tomekzaw, @greg-schroeder, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels Mar 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2024
@thienlnam
Copy link
Contributor

Updating the priority - this does not impact any real devices

@thienlnam thienlnam added Monthly KSv2 and removed Weekly KSv2 labels Mar 5, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

@tomekzaw @greg-schroeder @thienlnam this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Monthly KSv2 External Added to denote the issue can be worked on by a contributor labels Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

Copy link

melvin-bot bot commented Mar 11, 2024

@tomekzaw, @greg-schroeder, @thienlnam, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thienlnam thienlnam added Monthly KSv2 and removed Daily KSv2 labels Mar 12, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 12, 2024
@greg-schroeder
Copy link
Contributor

Closing this per team discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants