-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Entering certain diacritics such as à, á, â in the composer is broken (iOS Simulator) #36203
Comments
Job added to Upwork: https://www.upwork.com/jobs/~011af575af2fe9ca45 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Triggered auto assignment to @greg-schroeder ( |
Ah yes I think that's the difference, I'm using a Macbook with a US English keyboard, which doesn't have any keys with accents. To clarify, this is not an Expensify-specific feature, it's a native way to enter accents on MacOS, and so far I haven't seen any app where this didn't work. The other way is to long-press on a key like |
Btw, forgot to mention but this is most likely due to #35837. |
Cannot reproduce anymore, I believe that was the culprit and had been reverted. |
A similar issue also occurs on iOS simulator. The diacritics are correctly applied but the leading backtick is not removed. Using RNTextInput.movUsing MarkdownTextInput.mov |
This issue is reproducible in Live Markdown example app, reported as Expensify/react-native-live-markdown#181. |
@sobitneupane, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Okay - should we create a new issue or just change this one to focus on the iOS case? |
The behavior on native iOS will be fixed in Expensify/react-native-live-markdown#182. |
@tomekzaw to clarify, will that PR only fix native iOS? Cause the issue was also happening on web & desktop. Either way it's fine, we can keep this issue open to remember to also fix other platforms. |
@francoisl That's correct, this PR only fixes native iOS. We're still investigating the issue on web. |
All right - but I thought web was fixed by the revert of #35837? @francoisl |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@sobitneupane, @greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@tomekzaw @greg-schroeder @thienlnam this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks! |
@tomekzaw, @greg-schroeder, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Thoughts on a timeline for this one @tomekzaw? Just want to make sure I'm on the same page <3 |
@greg-schroeder Since this issue happens only on iOS simulators, we decided to deprioritize this and focus on the analogous issue happening on web first. Once we fix it for web, I will continue working on this issue. |
@tomekzaw, @greg-schroeder, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Updating the priority - this does not impact any real devices |
@tomekzaw @greg-schroeder @thienlnam this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:
Thanks! |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 ( |
@tomekzaw, @greg-schroeder, @thienlnam, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Closing this per team discussion |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.39-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @francoisl
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707435603099939
Action Performed:
Expected result:
à is entered in the composer
Actual result:
`a is entered in the chat
Same goes with Option+e , then letter, e.g. ´a is entered instead of á
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: