Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment - Pressing up key doesn't open editing composer on owned message #36173

Closed
1 of 6 tasks
lanitochka17 opened this issue Feb 8, 2024 · 9 comments
Closed
1 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.39-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open a report
  2. Send a message
  3. Press up key

Expected Result:

Editing composer should be opened on owned message

Actual Result:

Editing composer is not opened on owned message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6372431_1707420192667.Rename.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 8, 2024

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@iwiznia
Copy link
Contributor

iwiznia commented Feb 8, 2024

@thienlnam thienlnam assigned thienlnam and unassigned amyevans Feb 8, 2024
@thienlnam
Copy link
Contributor

Related to live markdown so taking over

@amyevans
Copy link
Contributor

amyevans commented Feb 8, 2024

Thanks!

@Skalakid
Copy link
Contributor

Skalakid commented Feb 9, 2024

The bug occurs because the live markdown input ref is missing the selectionStart prop that we use to detect arrow-up action. I will create PR with the fix

@thienlnam
Copy link
Contributor

We've reverted the offending PR #35837, so this is no longer a blocker

@thienlnam thienlnam added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@robertKozik
Copy link
Contributor

Tested on release 0.1.9. Issue is no longer reproductible - Expensify/react-native-live-markdown#176 seems to solve this

@melvin-bot melvin-bot bot removed the Overdue label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants