[$500] [HOLD for payment 2024-02-19] [HOLD for payment 2024-02-15] Request Money - The close button linked to "Request money. Get $250" is not functioning

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.38-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1, Tap on the FAB
2. Select "Request money" manually.
3. Add the desired amount.
4. Observe that the Close button at the bottom of the modal linked with "Request money, $250" is not working.

Expected Result:

The Close button should close the associated statement

Actual Result:

The Close button linked to "Request money. Get $250" is not functioning

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6370418_1707315345782.Screen_Recording_2024-02-07_at_5.44.14_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0140216d69adafd36d
• Upwork Job ID: 1758233563551039488
• Last Price Increase: 2024-02-15

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related #vip-split-p2p-chat-groups
CC @gabrielessner

[ZhenjaHorbach]

Looks like a regression from
#35058
Strange that we use here static value instead of referralContentType
https://github.com/Expensify/App/pull/35058/files#diff-7c10661835df3508dfce6e5e61fca9bd345559df2ac5c24f53cee9c5ea96732fR36
Plus that we left unnecessary code associated with the onCloseButtonPress param for ReferralProgramCTA

But just in case, a proposition

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request Money - The close button linked to "Request money. Get $250" is not functioning

What is the root cause of that problem?

The main problem with this issue is that we use static value for User.dismissReferralBanner

https://github.com/Expensify/App/pull/35058/files#diff-7c10661835df3508dfce6e5e61fca9bd345559df2ac5c24f53cee9c5ea96732fR36

What changes do you think we should make in order to solve the problem?

To fix this issue we can pass referralContentType instead of CONST.REFERRAL_PROGRAM.CONTENT_TYPES.REFER_FRIEND

What alternative solutions did you explore? (Optional)

NA

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request Money - The close button linked to "Request money. Get $250" is not functioning

What is the root cause of that problem?

App/src/components/ReferralProgramCTA.tsx

Lines 35 to 37 in 880e187

	const handleDismissCallToAction = () => {
	User.dismissReferralBanner(CONST.REFERRAL_PROGRAM.CONTENT_TYPES.REFER_FRIEND);
	};

type is hardcoded here

What changes do you think we should make in order to solve the problem?

It should be referralContentType instead of CONST.REFERRAL_PROGRAM.CONTENT_TYPES.REFER_FRIEND

(Optional) As a cleanup, remove all onCloseButtonPress props passed to ReferralProgramCTA throughout the app

---

Edit: @ZhenjaHorbach edited comment with formal proposal following template after my proposal so I am the first.

[marcaaron]

@cristipaval I feel like you would have the most context on this one. Do these proposals sound good?

[cristipaval]

looking now

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request Money - The close button linked to "Request money. Get $250" is not functioning

What is the root cause of that problem?

App/src/components/ReferralProgramCTA.tsx

Lines 35 to 37 in 880e187

	const handleDismissCallToAction = () => {
	User.dismissReferralBanner(CONST.REFERRAL_PROGRAM.CONTENT_TYPES.REFER_FRIEND);
	};

type is hardcoded here

What changes do you think we should make in order to solve the problem?

It should be referralContentType instead of CONST.REFERRAL_PROGRAM.CONTENT_TYPES.REFER_FRIEND

(Optional) As a cleanup, remove all onCloseButtonPress props passed to ReferralProgramCTA throughout the app

Edit: @ZhenjaHorbach edited comment with formal proposal following template after my proposal so I am the first.

Actually, you just took my explanation of this issue and made a proposition on it
Even with the information that we should remove unnecessary code

Therefore, just in case, I also made a proposal based on my comment which was long before your proposal

[cristipaval]

@ZhenjaHorbach I just assigned you to fix the issue. You quickly found the root cause and it looks good to me. Please open a PR asap given that this is a deploy blocker.

[cristipaval]

@puneetlath I took this one over because it's a regression from the PR that I was in charge of.

[ZhenjaHorbach]

@ZhenjaHorbach I just assigned you to fix the issue. You quickly found the root cause and it looks good to me. Please open a PR asap given that this is a deploy blocker.

No problem
Already started working

[mkhutornyi]

I agree that the one who first found the root cause and solution should be assigned, regardless of formal proposal or not.
I will just take this issue as reference when similar case comes up in the future.

[puneetlath]

Ok thanks @cristipaval

[lukemorawski]

will post a patch very soon

[cristipaval]

@lukemorawski This has been fixed already in this PR

[lukemorawski]

@cristipaval cool, thanks!

[marcaaron]

Removing the blocker as this is from yesterday and this has been fixed already.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix bug with The close button linked to "Request money. Get $250" is not functioning #36068

If no regressions arise, payment will be issued on 2024-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)
• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR: 20354 quick fix searchpage list refactor #35058
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: 20354 quick fix searchpage list refactor #35058 (comment)
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed. Seems like a onetime bug
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/370083

[joekaufmanexpensify]

@s77rt could you handle the BZ checklist so we can prep to issue payment this week?

[s77rt]

• The PR that introduced the bug has been identified: 20354 quick fix searchpage list refactor #35058
• The offending PR has been commented on: 20354 quick fix searchpage list refactor #35058 (comment)
• A discussion in #expensify-bugs has been started: Not needed. Seems like a onetime bug
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal

1. Login (preferably with a new account)
2. Click the FAB > Request money
3. Enter any amount and press Next
4. Verify that there is a referral modal that says "Request money, get $250."
5. Click the close button of that modal
6. Verify the modal is closed
7. Repeat steps 2 and 3
8. Verify that the referral modal is not visible

[joekaufmanexpensify]

BZ checklist complete, and all set to issue payment!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0140216d69adafd36d

[melvin-bot]

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

[joekaufmanexpensify]

We need to make the following payments:

• @s77rt - $500 for C+ review - paid via Upwork.
• @ZhenjaHorbach - $500 for PR. Paid via upwork.

[joekaufmanexpensify]

@s77rt offer sent for $500!

[joekaufmanexpensify]

@ZhenjaHorbach offer sent for $500!

[s77rt]

@joekaufmanexpensify Accepted! Thanks!

[joekaufmanexpensify]

@ZhenjaHorbach $500 sent and contract ended!

[joekaufmanexpensify]

@s77rt $500 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set. Thanks everyone!