Settings - Pressing the back button on the "Keyboard Shortcuts" page leads to a blank screen

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.36-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go the the Account settings > About > View keyboard shortcuts
2. Press back button

Expected Result:

Keyboard shortcuts modal should be closed and blank screen should not be displayed

Actual Result:

Pressing the back button on the "Keyboard Shortcuts" page leads to a blank screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365214_1706900698860.2024-02-02_22-18-46.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[johnmlee101]

Able to reproduce

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing the back button on the "Keyboard Shortcuts" page leads to a blank screen

What is the root cause of that problem?

OnBackButtonPress is missing in keyboardShortcutsPage

What changes do you think we should make in order to solve the problem?

Pass the prop onBackButtonPress={() => Navigation.goBack()} in HeaderWithBackButton

App/src/pages/KeyboardShortcutsPage.tsx

Line 48 in 3a610af

<HeaderWithBackButton title={translate('keyboardShortcutsPage.title')} />

What alternative solutions did you explore? (Optional)

N/A

[allgandalf]

I think this is not a deployBlock but rather a regression from #29063

Here is the regression commit

[shubham1206agra]

@hayata-suenaga This looks like related to goBack problems with Ideal Nav. Can you check this too?

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing the back button on the "Keyboard Shortcuts" page leads to a blank screen

What is the root cause of that problem?

We haven't added onBackButtonPress prop to HeaderWithBackButton in KeyboardShortcutsPage. We should add onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)} just like we do in AboutPage

App/src/pages/KeyboardShortcutsPage.tsx

Line 48 in 3a610af

<HeaderWithBackButton title={translate('keyboardShortcutsPage.title')} />

What changes do you think we should make in order to solve the problem?

Add onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)} to HeaderWithBackButton in KeyboardShortcutsPage.

Result

[hayata-suenaga]

Closing this issue to combine it with the existing issue.