[HOLD for payment 2024-02-20] [$250] [Wave 8] [Ideal Nav] Workspace Switcher Icon: Missing tool tip and wrong icon color

[hayata-suenaga]

Action Performed:

1. On a browser, hover over the Workspace Switcher icon (the avatar-like icon at the top-left color of the new Left Hand Pane (see the video).

Expected Result:

There should be a tooltip that displays Choose a workspace.
Only the background of the chevron icon should change, not the fill color of the chevron icon.

Please also read Shawn (our designer)'s additional comment here

Actual Result:

The tooltip doesn't appear.
The fill color of the chevron icon on hover changes on hover..

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-02-01.at.4.04.31.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01566d00a9005cba1a
• Upwork Job ID: 1753450501284016128
• Last Price Increase: 2024-02-02
• Automatic offers:
• dukenv0307 | Contributor | 28141432

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tooltip doesn't appear.
The color of the chevron icon on hover is incorrect.

What is the root cause of that problem?

1. The tooltip doesn't appear.
   We are not wrapping WorkspaceSwitcherButton into a tooltip
   

   App/src/components/WorkspaceSwitcherButton.tsx

   Line 41 in d9fd412

   <PressableWithFeedback

2. The color of the chevron icon on hover is incorrect.
   When we hover over the icon, the color of icon is buttonHoveredBG which is wrong color

App/src/components/WorkspaceSwitcherButton.tsx

Line 58 in d9fd412

fill: hovered ? theme.buttonHoveredBG : theme.icon,

What changes do you think we should make in order to solve the problem?

1. Wrap this component into a tooltip and the tooltip text can be confirmed by design team

App/src/components/WorkspaceSwitcherButton.tsx

Line 41 in d9fd412

<PressableWithFeedback

2. Change the hover color of icon. Design team can provide the correct hover color

App/src/components/WorkspaceSwitcherButton.tsx

Line 58 in d9fd412

fill: hovered ? theme.buttonHoveredBG : theme.icon,

What alternative solutions did you explore? (Optional)

NA

[shawnborton]

Also, want to clarify that for the small button over the workspace icon, just the button BG should be changing, not the icon color. We should be following our default button styles here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01566d00a9005cba1a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Upwork job price has been updated to $250

[hayata-suenaga]

There should be a tooltip that displays #33280 (comment).

@shawnborton could you confirm that the tooltip over the Workspace Switcher icon should display the full workspace name?

[shawnborton]

Hmm I would think the tool tip should actually say "Choose a workspace" since tapping this element takes you to that flow of the app. cc @trjExpensify @Expensify/design for a gut check there though.

[dannymcclain]

Hmm I would think the tool tip should actually say "Choose a workspace"

Totally agree.

[trjExpensify]

Yup, I also agree with that.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing tool tip and wrong icon color

What is the root cause of that problem?

We don't wrap PressableWithFeedback in a tooltip:

App/src/components/WorkspaceSwitcherButton.tsx

Lines 40 to 41 in d9fd412

	return (
	<PressableWithFeedback

For the design, we define hover color change for the Icon rather than the SubscriptAvatar component due to which only the Icon is hovered and not the whole button

App/src/components/WorkspaceSwitcherButton.tsx

Line 58 in d9fd412

fill: hovered ? theme.buttonHoveredBG : theme.icon,

App/src/components/SubscriptAvatar.tsx

Lines 104 to 105 in 3ab4e6e

	{subscriptIcon && (
	<View

What changes do you think we should make in order to solve the problem?

As for the PressableWithFeedback, wrap it in a tootip, as per comments from @shawnborton , we need to use switcher.headerTitle as the tooltip text (which is already defined in languages):

<Tooltip text={translate('switcher.headerTitle')}>
<PressableWithFeedback 
...
...
</Tooltip>

And for the design aspect, as per comments from @shawnborton , we need to hover the button rather than the Icon, we can do so by implementing the following changes, the results are shown first:

• Result:

simplescreenrecorder-2024-02-04_02.06.03.mp4

The changes required are:

First remove the existing Hover condition at subscriptIcon.fill, then pass the hover={hovered} prop to SubscriptAvatar

{({hovered}) => (
    <SubscriptAvatar
        .
        subscriptIcon={{
            ..
            fill: theme.icon,
        }}
        .
        hover={hovered}
    />
    )}

Then add hover as prop to SubscriptAvatar

And then set the style of the button to change on hover:

{subscriptIcon && (
    <View
        style={[
            .
            .
            hover && { backgroundColor: theme.buttonHoveredBG }
            .
        ]}
        .
    >

What alternative solutions did you explore? (Optional)

N/A

[hayata-suenaga]

@thesahindia please review proposals when you have time 🙇

[thesahindia]

@dukenv0307's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hayata-suenaga]

sorry I apparently clicked a wrong button and caused everyone to be unassigned 😓

@lakchote I'll keep assigning myself to this issue. I don't know whey Melvin assign you 🤷

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

Also, want to clarify that for the small button over the workspace icon, just the button BG should be changing, not the icon color. We should be following our default button styles here.

hey @thesahindia, according to comments from @shawnborton , he expected that the button BG be changed and not the icon, but @dukenv0307 proposal states to change the icon color:

Change the hover color of icon. Design team can provide the correct hover color

And in my proposal i have followed the comments and updates the BG of the button rather than the icon, so isn’t my RCA more accurate?

@hayata-suenaga @lakchote @Christinadobrzyn

[thesahindia]

he expected that the button BG be changed and not the icon, but @dukenv0307 proposal states to change the icon color:

We generally handle these things in the PR. The issue is minor and the first proposal was good enough.

[dukenv0307]

@thesahindia The PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add tooltip and change background color of subscription icon #35795

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

• @thesahindia requires payment through NewDot Manual Requests
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

hi! Sorry I'm ooo sick today - I'll follow up on this tomorrow

[Christinadobrzyn]

Payment summary

Contributor: $250 @dukenv0307 (paid in Upwork - https://www.upwork.com/nx/wm/offer/28141432)
Contributor+: $250 @thesahindia (in NewDot)

Eligible for 50% #urgency bonus? NA

Do we need a regression test for this?

[thesahindia]

Do we need a regression test for this?

We don't need a specific test for this.

[Christinadobrzyn]

awesome! thanks for confirming @thesahindia

This is paid out based on this payment summary - #35618 (comment)

Closing - feel free to reach out with any questions!

[JmillsExpensify]

$250 approved for @thesahindia